Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a question about ATE RMSE results on ScanNet #26

Closed
wangm-buaa opened this issue Jul 28, 2023 · 5 comments
Closed

a question about ATE RMSE results on ScanNet #26

wangm-buaa opened this issue Jul 28, 2023 · 5 comments
Labels
good first issue Good for newcomers

Comments

@wangm-buaa
Copy link

Hi, thanks for your excellent work!
I have a question after evaluating scene0000_00 with the code you provided. There are two types results pose_x.png and pose_r_x.png generated by following codes.

Co-SLAM/coslam.py

Lines 675 to 676 in 2329d09

pose_evaluation(self.pose_gt, self.est_c2w_data, 1, os.path.join(self.config['data']['output'], self.config['data']['exp_name']), i)
pose_evaluation(self.pose_gt, pose_relative, 1, os.path.join(self.config['data']['output'], self.config['data']['exp_name']), i, img='pose_r', name='output_relative.txt')

It seems that using pose_relative can achieve better ATE RMSE result, while the other result is more similar as the one on paper.
I wonder which result is the one you provided on paper and why you didn't use the other one.
Thank you!

@HengyiWang
Copy link
Owner

Hi @wangm-buaa, thank you for your interest in our work. We use pose_relative in the paper. The difference between those two is that in pose_relative, we save the relative poses of the non-keyframe with respect to the previous keyframe while in est_c2w_data , the non-keyframe poses are saved with respect to the first frame. Keyframe poses will be updated after performing BA, then all poses in pose_relative would change. Most of the time, the results using pose_relative are better meaning that BA is working very well. Thus, I keep both results in the code :)

Please note that in ScanNet, we run each scene 5 times and report the average results. Also, I did some refactoring of the code in the released version, so you might get slightly better tracking results.

@wangm-buaa
Copy link
Author

Thanks for your reply and help!

@HengyiWang HengyiWang added the good first issue Good for newcomers label Jul 28, 2023
@HengyiWang HengyiWang pinned this issue Jul 28, 2023
@ArlenCHEN
Copy link

Following your discussions, is it for Co-SLAM to have better results if we use pose_relative instead of est_c2w_data to perform the ray tracing in tracking_render and global_BA?

@HengyiWang
Copy link
Owner

Hi @ArlenCHEN, we only use the keyframe rays and the corresponding poses for global BA.

@ArlenCHEN
Copy link

Thanks @HengyiWang.

Another question: How do you generate the online reconstruction video? Did you release the code for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants