Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLEANUP: Bump requirement to R (>= 3.1.1) and drop NAMESPACE workarounds #3

Closed
HenrikBengtsson opened this issue Apr 21, 2015 · 1 comment

Comments

@HenrikBengtsson
Copy link
Owner

Now (2015-04-16) when R 3.2.0 is out, bump requirement to R (>= 3.1.1). By choosing 3.1.1 (July 2014) and not 3.1.0 (April 2014), we can also replying BioC (>= 3.0) (October 2014). This is also what next release of R.filesets will do.

This allows us to drop the NAMESPACE workaround for the max. 500 S3 methods limitation in R (< 3.0.2), e.g.

if (getRversion() >= "3.1.0") {
  S3method("fixSearchPath", "AromaPackage")
  S3method("fixSearchPathInternal", "AromaPackage")
  S3method("patch", "AromaPackage")
}

This will also remove the (false) R CMD check NOTE:

* checking package namespace information ... NOTE
R < 3.0.2 had a limit of 500 registered S3 methods: found 841
@HenrikBengtsson HenrikBengtsson added this to the 2.14.0 release milestone Apr 21, 2015
@HenrikBengtsson HenrikBengtsson changed the title CLEANUP: Bump requirement to R (>= 3.1.0) and drop NAMESPACE workaroundds CLEANUP: Bump requirement to R (>= 3.1.0) and drop NAMESPACE workarounds Apr 22, 2015
@HenrikBengtsson HenrikBengtsson changed the title CLEANUP: Bump requirement to R (>= 3.1.0) and drop NAMESPACE workarounds CLEANUP: Bump requirement to R (>= 3.1.1) and drop NAMESPACE workarounds Apr 22, 2015
@HenrikBengtsson
Copy link
Owner Author

Done in commit 955adf6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant