Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't save downloaded videos to nfs:// or smb:// directory #7

Open
Nwardezir opened this issue May 19, 2013 · 10 comments
Open

Can't save downloaded videos to nfs:// or smb:// directory #7

Nwardezir opened this issue May 19, 2013 · 10 comments

Comments

@Nwardezir
Copy link

No matter how hard I tried, giving all rights and access to the directories, downloaded videos aren't copied on a nfs or smb chosen directory in Youtube addon settings.

Log available here : http://www.xbmclogs.com/show.php?id=20258

As shown, video are kept into the initial /var/mobile/Library/Preferences/XBMC/userdata/addon_data/script.module.simple.downloader/ directory and never copied.
See Error message at lines 342 and 343.

Btw, the log I linked is for an smb-type directory only, but the issue is the same for nfs (tested, same error message, still doesn't work)

@TobiasTheViking
Copy link
Collaborator

The file move is done using the "xbmcvfs" library provided by xbmc.

I would suggest you try upgrading your xbmc to the latest version, and if you still encounter the problem you should take it up with team xbmc. The xbmcvfs library we utilize was made specifically to support nfs and smb shares.

@Nwardezir
Copy link
Author

Err ... ok.
But, as a side note, every test I ran was on last version Frodo 12.2.

@Nwardezir
Copy link
Author

Tried to get in touch with "team xbmc", dunno if this is the proper way to do it : http://forum.xbmc.org/showthread.php?tid=102371&pid=1426806#pid1426806 ... we'll see.

@TobiasTheViking
Copy link
Collaborator

I understand the frustration of "It's them". But really there ain't much i think i can do.

You could also try the #xbmc channel on freenode. The good thing there is, if you find some xbmc guy that says "oh, it's the youtube downloader, not us", you can pester me directly in there.

@TobiasTheViking
Copy link
Collaborator

Btw, do note that amet's message(that you quoted) says what i says.
"unless the addons that you are using are modified to use xbmcvfs.copy('src', 'dest') you will not be able to save to SMB:// "

We are using xbmcvfs.

@Nwardezir
Copy link
Author

Yep, that's the problem, you are using xbmcvfs but I still have error when it comes to moving a downloaded outube video to an SMB directory :

03:13:38 T:122019840 NOTICE: [YouTube-4.4.4] _processQueue : 'Moving u'/var/mobile/Library/Preferences/XBMC/userdata/addon_data/script.module.simple.downloader/-SHAKA RECORDING--[54_qEk-0tpY].mp4' to u'smb://SLAUGHTERLOGY/Videos/Vrac/FromTheNet/-SHAKA RECORDING--[54_qEk-0tpY].mp4''
03:13:38 T:122019840 ERROR: MoveFile - cant move file </var/mobile/Library/Preferences/XBMC/userdata/addon_data/script.module.simple.downloader/-SHAKA RECORDING--[54_qEk-0tpY].mp4>. trying lower case
</var/mobile/library/preferences/xbmc/userdata/addon_data/script.module.simple.downloader/-shaka recording--[54_qek-0tpy].mp4>

I hope someone will find a fix here or over there :(

@yannrouillard
Copy link

Hi,

This bug is still present. I opened a bug on xbmc about it xbmc/xbmc#4847

I workarounded it on my installation by having script.module.simple.downloader try a copy/delete if rename doesn't work (modification here https://github.com/yannrouillard/xbmc-simple-downloader).

Yann

@yannrouillard
Copy link

github bug tracker is not used by xbmc, I had to open it on trac: http://trac.xbmc.org/ticket/15271

@yannrouillard
Copy link

The xbmc upstream answer is that rename should only be used for local files or folder, see http://trac.xbmc.org/ticket/15271#comment:4.

Would you consider a patch like this to be able to handle this case ? yannrouillard/xbmc-simple-downloader@8a7649f

@TobiasTheViking
Copy link
Collaborator

Yeah, i'll take that, just make a PR to the repo and i'll pull it.

But a rename/move not working, that's just stupid. Really really stupid. Especially considering, as i said before, that that was the point, that it should work agnostically.

I'm closing this bug as i expect a PR.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants