Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep ips of last run and only change when different #1

Closed
osr00 opened this issue May 27, 2020 · 2 comments
Closed

keep ips of last run and only change when different #1

osr00 opened this issue May 27, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@osr00
Copy link

osr00 commented May 27, 2020

For performance reasons it would be good if the application stores the ips it sended last time and first checks only if they are changed. Only when changed it should communicate with the netcup server.

This way it would be possible to start the app once per minute via cron and it only accesses netcup if needed. This would reduces network traffic a lot.

@Hentra
Copy link
Owner

Hentra commented May 28, 2020

This sounds reasonable. I will try and see if I can implement this behaviour. It requires a cache solution which is currently not build into the system.

@Hentra Hentra added the enhancement New feature or request label May 28, 2020
@Hentra Hentra self-assigned this May 28, 2020
@Hentra
Copy link
Owner

Hentra commented May 28, 2020

Current idea on the implementation of the ip cache:

  • The cache file location must be specified in the configuration as ip-cache
  • The usage of a cache must be optional
  • The time on which the cache is valid should be specified in the configuration cache-timout (not sure this is a required feature but its nice to have)

@Hentra Hentra closed this as completed in ee4ac25 Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants