Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

int_party.c warning #1725

Closed
4 tasks done
VMGlab opened this issue May 2, 2017 · 3 comments
Closed
4 tasks done

int_party.c warning #1725

VMGlab opened this issue May 2, 2017 · 3 comments
Labels
component:core Affecting the Hercules core (i.e. not the game mechanics directly) severity:2-fair Incorrect gaming mechanics, database warnings

Comments

@VMGlab
Copy link

VMGlab commented May 2, 2017 •
edited

Issue Prelude

  • I have not modified the source prior to reproducing this issue.
  • I am using the latest version of Hercules.
  • I am aware that this report will be closed or deleted if it becomes obvious that I am stating the false.

Description

I just noticed this warning while compiling, even though I haven't modified any part of int_party.c
WARNING ERROR: 1>..\src\char\int_party.c(320): warning C4018: '<=' : signed/unsigned mismatch

Branch(es):

  • master

Git revision (src): 'ff8429634673855a1dc6e2924d4534aec8de6507'
@dastgirp
Copy link
Member

dastgirp commented May 2, 2017

Known issue.
Related pr:#1653
Branch: https://github.com/HerculesWS/Hercules/tree/signed-array-index (I guess haru was working on it, since the pr didn't actually fix the core error and just suppressed the warning)

@dastgirp dastgirp added component:core Affecting the Hercules core (i.e. not the game mechanics directly) severity:2-fair Incorrect gaming mechanics, database warnings status:confirmed Issue is valid and can be reproduced labels May 2, 2017
@kyeme
Copy link

kyeme commented May 2, 2017

Duplicate of #1434

@VMGlab
Copy link
Author

VMGlab commented May 2, 2017

Thank you @dastgir @kyeme

@dastgirp dastgirp closed this as completed May 2, 2017
@ghost ghost removed the status:confirmed Issue is valid and can be reproduced label May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:core Affecting the Hercules core (i.e. not the game mechanics directly) severity:2-fair Incorrect gaming mechanics, database warnings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dastgirp @kyeme @VMGlab