Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@channel ban #channel not saved #1858

Open
3 tasks done
bWolfie opened this issue Oct 14, 2017 · 4 comments
Open
3 tasks done

@channel ban #channel not saved #1858

bWolfie opened this issue Oct 14, 2017 · 4 comments
Labels
invalid Issue isn't a Hercules bug (user mistake, intentional behavior, unsupported setup, etc) type:bug Issue is a bug or describes an incorrect behavior that should be fixed

Comments

@bWolfie
Copy link
Contributor

bWolfie commented Oct 14, 2017

Issue Prelude

  • I have not modified the source prior to reproducing this issue.
  • I am using the latest version of Hercules.
  • I am aware that this report will be closed or deleted if it becomes obvious that I am stating the false.

Description

Sorry for always reporting so much.
When I use @channel ban #irc, the bans don't persist once the server closes.

Current Behavior

Once you close the server ./athena-start stop, all channel bans are cleared.

Expected Behavior

I would expect these bans to persist and be permanent.

Steps To Reproduce The Issue

  1. Ban somebody in a channel, e.g. @channel ban #irc MyCharacter
  2. Restart your server ./athena-start stop, ./athena-start start
  3. Check @channel banlist #irc, it will be empty.
@Helianthella
Copy link
Member

Channels are not stored in the database so it's not that your settings get reset but rather that they are never saved in the first place. If you have repeat offenders, just ban or jail them

@dastgirp
Copy link
Member

I guess we should store them in database? Banning them for talking shit/irritating is not appropriate.

@Helianthella Helianthella added invalid Issue isn't a Hercules bug (user mistake, intentional behavior, unsupported setup, etc) type:bug Issue is a bug or describes an incorrect behavior that should be fixed labels Oct 14, 2017
@bWolfie
Copy link
Contributor Author

bWolfie commented Oct 24, 2017

haha its getting annoying having to re-ban the same players over and over again :P

@bWolfie
Copy link
Contributor Author

bWolfie commented Jun 29, 2018

Bump. Channel ban is a useless feature as it stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Issue isn't a Hercules bug (user mistake, intentional behavior, unsupported setup, etc) type:bug Issue is a bug or describes an incorrect behavior that should be fixed
Projects
None yet
Development

No branches or pull requests

3 participants