Documentation and warnings related to mapflags scripts commands

[haarenas]

Describe the bug
Documentation of commands like setmapflag, gatmapflag and removemapflag specify the use of mf_xxx constants in lower case, but if you use lower case they dont do anything. I looked at script.h for those constants and they are all UPPER CASE.

Using those constants in upper case make those commands work, but a warning appears in the terminal/console saying you should use lower case.

[AnnieRuru]

really ? I just test one of my script that having setmapflag
--> this one
works perfectly fine

no, the constants you should be looking for, should be
https://github.com/HerculesWS/Hercules/blob/stable/doc/constants.md#mapflags
and everything there is lower case

btw I do agree our emotions constants should be in UPPER_CASE

Hercules/src/map/clif.h

Lines 147 to 238 in 82d634a

	typedef enum emotion_type {
	E_GASP = 0, // /!
	E_WHAT, // /?
	E_HO,
	E_LV,
	E_SWT,
	E_IC,
	E_AN,
	E_AG,
	E_CASH, // /$
	E_DOTS, // /...
	E_SCISSORS, // /gawi --- 10
	E_ROCK, // /bawi
	E_PAPER, // /bo
	E_KOREA,
	E_LV2,
	E_THX,
	E_WAH,
	E_SRY,
	E_HEH,
	E_SWT2,
	E_HMM, // --- 20
	E_NO1,
	E_NO, // /??
	E_OMG,
	E_OH,
	E_X,
	E_HLP,
	E_GO,
	E_SOB,
	E_GG,
	E_KIS, // --- 30
	E_KIS2,
	E_PIF,
	E_OK,
	E_MUTE, // red /... used for muted characters
	E_INDONESIA,
	E_BZZ, // /bzz, /stare
	E_RICE,
	E_AWSM, // /awsm, /cool
	E_MEH,
	E_SHY, // --- 40
	E_PAT, // /pat, /goodboy
	E_MP, // /mp, /sptime
	E_SLUR,
	E_COM, // /com, /comeon
	E_YAWN, // /yawn, /sleepy
	E_GRAT, // /grat, /congrats
	E_HP, // /hp, /hptime
	E_PHILIPPINES,
	E_MALAYSIA,
	E_SINGAPORE, // --- 50
	E_BRAZIL,
	E_FLASH, // /fsh
	E_SPIN, // /spin
	E_SIGH,
	E_DUM, // /dum
	E_LOUD, // /crwd
	E_OTL, // /otl, /desp
	E_DICE1,
	E_DICE2,
	E_DICE3, // --- 60
	E_DICE4,
	E_DICE5,
	E_DICE6,
	E_INDIA,
	E_LUV, // /love
	E_RUSSIA,
	E_VIRGIN,
	E_MOBILE,
	E_MAIL,
	E_CHINESE, // --- 70
	E_ANTENNA1,
	E_ANTENNA2,
	E_ANTENNA3,
	E_HUM,
	E_ABS,
	E_OOPS,
	E_SPIT,
	E_ENE,
	E_PANIC,
	E_WHISP, // --- 80
	E_YUT1,
	E_YUT2,
	E_YUT3,
	E_YUT4,
	E_YUT5,
	E_YUT6,
	E_YUT7,
	/* ... */
	E_MAX
	} emotion_type;

the source use upper case, but script constants use lower case
https://github.com/HerculesWS/Hercules/blob/stable/doc/constants.md#emotes
however changing that will throw errors on many scripts

[Emistry]

for case-sensitivity may refer @MishimaHaruna's #685 (comment) for reference.

[Emistry]

Mapflags has been refactored in #2654 .