Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTB card has silence immunity #2605

Closed
anyamichael opened this issue Jan 6, 2020 · 6 comments
Closed

GTB card has silence immunity #2605

anyamichael opened this issue Jan 6, 2020 · 6 comments
Assignees
Labels
complexity: 2-moderate component:core Affecting the Hercules core (i.e. not the game mechanics directly) component:mechanics:skills Affecting the skills' game mechanics severity:5-critical Crashes, security issues and exploits status:confirmed Issue is valid and can be reproduced

Comments

@anyamichael
Copy link

anyamichael commented Jan 6, 2020

Golden thief bug card script has wrong script
//Status that are blocked by Golden Thief Bug card or Wand of Hermod
if (status->isimmune(bl))
switch (type) {
case SC_DEC_AGI:
case SC_SILENCE:
case SC_COMA:
case SC_INC_AGI:
case SC_BLESSING:
case SC_SLOWPOISON:
case SC_IMPOSITIO:
case SC_LEXAETERNA:
case SC_SUFFRAGIUM:
case SC_BENEDICTIO:
case SC_PROVIDENCE:
case SC_KYRIE:
case SC_ASSUMPTIO:
case SC_ANGELUS:
case SC_MAGNIFICAT:
case SC_GLORIA:
case SC_WINDWALK:
case SC_MAGICROD:
case SC_ILLUSION:
case SC_STONE:
case SC_QUAGMIRE:
case SC_NJ_SUITON:
case SC_SWING:
return 0;
}
it has silence
Screen Shot 2020-01-06 at 18 03 29

@hemagx hemagx self-assigned this Jan 6, 2020
@hemagx hemagx added complexity: 2-moderate component:core Affecting the Hercules core (i.e. not the game mechanics directly) component:mechanics:skills Affecting the skills' game mechanics severity:5-critical Crashes, security issues and exploits status:confirmed Issue is valid and can be reproduced labels Jan 6, 2020
@hemagx
Copy link
Contributor

hemagx commented Jan 6, 2020

Confirmed in aegis, this also affects many other skills.

@hemagx
Copy link
Contributor

hemagx commented Jan 6, 2020

I will compile full list soon for pre-re/re

@Xelliekins
Copy link

Xelliekins commented Apr 14, 2020

Stone Curse and Coma are also status effects that are independent of skills and shouldn't be blocked from sources such as card/weapon sources or tarot.

@GreenStage
Copy link

any news on this?

@Playtester
Copy link

Might want to mark this as duplicate of: #2913

@skyleo
Copy link
Contributor

skyleo commented Apr 15, 2024

This should be fixed since #3155

@skyleo skyleo closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: 2-moderate component:core Affecting the Hercules core (i.e. not the game mechanics directly) component:mechanics:skills Affecting the skills' game mechanics severity:5-critical Crashes, security issues and exploits status:confirmed Issue is valid and can be reproduced
Projects
None yet
Development

No branches or pull requests

6 participants