Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not support orientation for now #60

Closed
bobz392 opened this issue Jan 29, 2017 · 7 comments
Closed

Not support orientation for now #60

bobz392 opened this issue Jan 29, 2017 · 7 comments

Comments

@bobz392
Copy link

bobz392 commented Jan 29, 2017

If your change device orientation, then BOOM...
img_0551

@lkzhao
Copy link
Collaborator

lkzhao commented Jan 29, 2017

I am not seeing this. Did it happen during a transition?

@lkzhao
Copy link
Collaborator

lkzhao commented Jan 29, 2017

simulator screen shot jan 29 2017 12 37 43 pm

@bobz392
Copy link
Author

bobz392 commented Jan 30, 2017

@lkzhao hum.. it happen after a transition.
I present to a new view controller and change orientation after transition.
It happens when I dismiss this view controller.

@yonicsurny
Copy link

Hi, I've noticed the same issue.

In my case, say I start the app in landscape, push a new controller on the navigation controller stack, rotate to portrait and pop the new controller, then the previous controller frame is incorrect and I get a black area on the right side (same behaviour if I start in portait and rotate to landscape, the black area is at the bottom).

@lkzhao
Copy link
Collaborator

lkzhao commented Feb 2, 2017

Ok. It is probably a regression from fixing #36. I will fix it today.

@lkzhao
Copy link
Collaborator

lkzhao commented Feb 2, 2017

Should be fixed on the latest master:

pod "Hero", :git=>"https://github.com/lkzhao/Hero.git"

@yonicsurny
Copy link

Can't reproduce the issue with the latest version (0.1.3)

Cheers 👍

@lkzhao lkzhao closed this as completed Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants