Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animations won't work after switching and switching back on tabBarController #733

Open
SaeeSaadat opened this issue Apr 3, 2022 · 1 comment
Assignees
Labels

Comments

@SaeeSaadat
Copy link

What did you do?

I have a main navigationController in my app that navigates between login page and the main tabBar. the tabBar it self has two child controllers which are both navigationControllers

there is this weird thing with "isHeroEnabled" in the navigationController where if i set it to true in viewDidLoad, hero animations won't work! but if i don't touch it it'll work fine! but that's not the problem!

when the tabbar loads the first page works perfectly fine with all the animations and everything! the problem begins when i switch to next tab and then go back to my first page and find it with no animation! it just awkwardly slides to right to show the next viewController as if hero is not enabled (tho i checked and indeed it was enabled for both vc's and the navigation controller)

What did you expect to happen?

for animations to work!

What happened instead?

they did not!

General Information

  • Hero Version: 1.6.1

  • iOS Version(s): 13

  • Swift Version: 5

  • Devices/Simulators: iPhone 13 pro max

  • Reproducible in Examples? (Yes/No): yes

@SaeeSaadat SaeeSaadat changed the title animations won't work after switching and switching back to viewController animations won't work after switching and switching back on tabBarController Apr 3, 2022
@SaeeSaadat
Copy link
Author

Screen.Recording.2022-04-03.at.12.50.58.PM.mov

here's a little demo of what's happening!
btw you see how everything FLASHES while the transition is happening! what's that all about? it's like everything get's 1.0 alpha and then goes back to normal it's weird!

@JoeMatt JoeMatt self-assigned this Jul 6, 2022
@JoeMatt JoeMatt added the bug? label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants