Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation doesn't work when navigationController pushing screen #753

Open
ZHNursultan opened this issue Nov 14, 2022 · 4 comments
Open

Animation doesn't work when navigationController pushing screen #753

ZHNursultan opened this issue Nov 14, 2022 · 4 comments

Comments

@ZHNursultan
Copy link

Why Hero Transition Animation doesn't work when I push a new viewController into UINavigationController or setting as a root view controller?

@JoeMatt
Copy link
Collaborator

JoeMatt commented Nov 15, 2022

Gonna need a little more info.

Sample code?

@ZHNursultan
Copy link
Author

ZHNursultan commented Nov 21, 2022

@JoeMatt of course sorry for late answer
It works if I present it. But doesn't if I push.

let onboarding2 = Onboarding2ViewController(viewModel: .init())
onboarding2.hero.isEnabled = true
router.push(onboarding2)

router is UINavigationController
router.push(onboarding2) is animated true
router is hero enabled true

@niralishaha25
Copy link

I am facing same issue on iOS 16

@JoeMatt
Copy link
Collaborator

JoeMatt commented Dec 3, 2022

Unfortunately, my time/role on this project is more as a project manager.

If anyone can debug and write a fix, even something that needs some cleanup, I'd be more than happy to test and merge or improve. Still, I don't have the cycles with all my other projects to debug this at the moment, especially since I'm not using Hero myself as my main apps have moved over to SwiftUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants