Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Search to "Your Bounties" #51

Closed
starpause opened this issue Oct 21, 2023 · 11 comments
Closed

Apply Search to "Your Bounties" #51

starpause opened this issue Oct 21, 2023 · 11 comments
Assignees
Labels
READY Ready to start work on

Comments

@starpause
Copy link
Contributor

starpause commented Oct 21, 2023

Developer Direction

Apply Search to both "Browse Bounties" and "Your Bounties".

Journey

As a funder, after I create a bounty I want to share it.

Issue

It's hard to find a bounty after I create it. Going to the bounties page doesn't show the bounty, which makes me think that it didn't actually get published/posted.

Image

If I go under "Your Bounties" I can find it:

Image

Implementation Idea

Display all active bounties, including ones I created, on this page https://heroes.build/bounties

@AngelBlock
Copy link
Contributor

@starpause how long did you wait, its a lag a 15-30s, due to indexer/rpc slowness

@starpause
Copy link
Contributor Author

The bounties I create are visible under "Your Bounties" but not under "Browse Bounties"

jCkKdIzV6I

@starpause starpause added the READY Ready to start work on label Oct 30, 2023
@starpause
Copy link
Contributor Author

starpause commented Oct 30, 2023

This bug has something to do with search filtering. After a search is applied the relevant bounties are showing up in "Your Bounties" but not under "Browse Bounties". If I remove the search then the bounties are visible in both places.

After experimenting more I see that search only applies to "Browse Bounties" not "Your Bounties". To prevent the disorientation that I experienced please apply Search to both "Browse Bounties" and "Your Bounties".

@starpause starpause changed the title "Browse Bounties" does not show Bounties I created Apply Search to "Your Bounties" Oct 30, 2023
@Rostyksv Rostyksv assigned Rostyksv and unassigned AngelBlock Oct 31, 2023
@Rostyksv
Copy link

Rostyksv commented Nov 2, 2023

Done, please check

@starpause
Copy link
Contributor Author

Looks good on testing.

@Kisgus Kisgus transferred this issue from another repository Nov 16, 2023
@starpause
Copy link
Contributor Author

@Rostyksv please push to stage/production

@rostyslav-dzhuman
Copy link
Collaborator

This issue is related to #55. Please check it comprehensively before deploying to prod.

@starpause
Copy link
Contributor Author

#55 looking good on test so this can be pushed along with it.

@starpause starpause self-assigned this Nov 24, 2023
@cudam321
Copy link
Collaborator

@starpause how do i test this? Search doesn't seem applied to both for me
heroes gif

@starpause
Copy link
Contributor Author

under windows 11 chrome latest:

here is search working for me inside of "your bounties"

TsuSN5aIG1

here is search working for me at the "browse bounties" level

8ijPoLkqKT

is it possible in your screenshot that a search term is in the text of the bounty rather than the title?

@starpause
Copy link
Contributor Author

Working to my specification in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY Ready to start work on
Projects
None yet
Development

No branches or pull requests

5 participants