Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode doesn't display correctly in error when using Add To Steam with invalid steam path #1867

Closed
idbrii opened this issue Oct 5, 2022 · 1 comment
Assignees
Labels
bug:confirmed Something isn't working.

Comments

@idbrii
Copy link

idbrii commented Oct 5, 2022

Describe the bug

If your steam path is invalid, when Heroic notifies you of an error, it has unicode characters which make the incorrect path hard to read.

Add logs

(20:07:34) INFO:    [Legendary]:       Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary --version
(20:07:35) INFO:    [Legendary]:       Legendary location: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary
(20:07:35) INFO:    [Gog]:             GOGDL location: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
(20:07:35) INFO:    [Backend]:         

Heroic Version: 2.4.3 Chopper
Legendary Version:  0.20.28 Dark Energy (hotfix #2)
OS: Freedesktop SDK KERNEL: 5.13.0-valve21.1-1-neptune-02211-gc54cda5a36f3 ARCH: x64
CPU: AMD Custom APU 0405 @1.82 GOVERNOR: schedutil
RAM: Total: 14.49 GiB Available: 12.71 GiB
GRAPHICS: GPU0: VanGogh [AMD Custom GPU 0405] VRAM: 512MB DRIVER:  
PROTOCOL: x11

(20:07:35) INFO:    [Gog]:             Getting data about the user
(20:07:35) WARNING: [Backend]:         Failed to register protocol with OS.
(20:07:35) INFO:    [Backend]:         AreWeAntiCheatYet data downloaded
(20:07:36) INFO:    [Gog]:             Saved user data to config
(20:07:36) INFO:    [Frontend]:        Refreshing Library
(20:07:36) INFO:    [Legendary]:       Refreshing library...
(20:07:36) INFO:    [Legendary]:       Refreshing Epic Games...
(20:07:36) INFO:    [Gog]:             Getting GOG library
(20:07:36) INFO:    [Legendary]:       Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary list
(20:07:36) INFO:    [Gog]:             Number of library pages: 1
(20:07:37) INFO:    [Gog]:             Saved games data
(20:07:37) INFO:    [Backend]:         Downloaded Winetricks
(20:07:38) INFO:    [Legendary]:       Updating game list
(20:07:38) INFO:    [Legendary]:       Game List Updated
(20:07:38) INFO:    [Legendary]:       Checking for game updates.
(20:07:38) INFO:    [Legendary]:       Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary list-installed --check-updates --tsv
(20:07:40) INFO:    [Legendary]:       Found 0 game(s) to update
(20:07:40) INFO:    [Gog]:             Found 0 game(s) to update
(20:07:41) DEBUG:   [Backend]:         Unable to load Steam Libraries, libraryfolders.vdf not found
(20:10:36) DEBUG:   [Backend]:         Unable to load Steam Libraries, libraryfolders.vdf not found
(20:12:28) DEBUG:   [Backend]:         Unable to load Steam Libraries, libraryfolders.vdf not found
(20:12:43) INFO:    [Legendary]:       Getting Info from Epic API
(20:12:43) INFO:    [Legendary]:       Getting Info from Epic API
(20:12:43) INFO:    [Legendary]:       Getting more details with 'legendary info'
(20:12:44) INFO:    [Legendary]:       Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary --pretty-json info Quail --platform Windows --json
(20:12:53) DEBUG:   [Legendary]:       Using cached install info
(20:12:53) INFO:    [Legendary]:       Checking if EOS Overlay is enabled: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary eos-overlay info --prefix /home/deck/Games/Heroic/Prefixes/AncientEnemy/pfx
(20:13:00) ERROR:   [Shortcuts]:       /home/deck/.steam/steamm/userdata does not exist. Can't add/remove game to/from Steam!
(20:14:32) DEBUG:   [Backend]:         Unable to load Steam Libraries, libraryfolders.vdf not found
(20:14:46) INFO:    [Backend]:         Writing config for Heroic
(20:14:46) INFO:    [Backend]:         {
  "altLegendaryBin": "",
  "altGogdlBin": "",
  "addDesktopShortcuts": false,
  "addStartMenuShortcuts": false,
  "autoInstallDxvk": false,
  "autoInstallVkd3d": false,
  "preferSystemLibs": false,
  "customWinePaths": [],
  "checkForUpdatesOnStartup": false,
  "darkTrayIcon": true,
  "defaultInstallPath": "/home/deck/Games/Heroic",
  "defaultSteamPath": "/home/deck/.steam/steam",
  "defaultWinePrefix": "/home/deck/Games/Heroic/Prefixes",
  "disableController": false,
  "egsLinkedPath": "",
  "maxRecentGames": 5,
  "maxWorkers": 0,
  "minimizeOnLaunch": false,
  "nvidiaPrime": false,
  "enviromentOptions": [],
  "wrapperOptions": [],
  "showFps": false,
  "showUnrealMarket": false,
  "useGameMode": false,
  "wineCrossoverBottle": "Heroic",
  "winePrefix": "/home/deck/.wine",
  "wineVersion": {
    "bin": "",
    "name": "Default Wine - Not Found",
    "type": "wine"
  },
  "eacRuntime": false,
  "battlEyeRuntime": false
}
(20:14:59) DEBUG:   [Legendary]:       Using cached install info
(20:14:59) INFO:    [Legendary]:       Checking if EOS Overlay is enabled: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary eos-overlay info --prefix /home/deck/Games/Heroic/Prefixes/AncientEnemy/pfx
(20:15:05) INFO:    [Gog]:             Getting game metadata.
(20:15:05) INFO:    [Gog]:             Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl info 1651064074 --token <redacted> --lang=en-US --os windows
(20:15:06) INFO:    [Legendary]:       Checking if EOS Overlay is enabled: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary eos-overlay info --prefix /home/deck/Games/Heroic/Prefixes/Disjunction/pfx
(20:15:11) DEBUG:   [Legendary]:       Using cached install info
(20:15:11) INFO:    [Legendary]:       Checking if EOS Overlay is enabled: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary eos-overlay info --prefix /home/deck/Games/Heroic/Prefixes/AncientEnemy/pfx
(20:15:18) INFO:    [Shortcuts]:       Prepare Steam images for Ancient Enemy
(20:15:19) INFO:    [Shortcuts]:       Ancient Enemy was successfully added to Steam.
(20:18:09) DEBUG:   [Legendary]:       Using cached install info
(20:18:09) INFO:    [Legendary]:       Checking if EOS Overlay is enabled: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary eos-overlay info --prefix /home/deck/Games/Heroic/Prefixes/AncientEnemy/pfx

Steps to reproduce

  1. Go to 'Settings' > Other
  2. Change "Default Steam Path" to any path that doesn't have steam (/home/deck/.steam/steamm in my case)
  3. Go to Library
  4. Click on a game
  5. Click on Tools
  6. Click Add to Steam
  7. See error

Expected behavior

The error message correctly displays unicode characters or doesn't contain any.

Screenshots

Screenshot_20221004_201348

System Information

  • OS [e. g. "Ubuntu"]: SteamOS 3.3.1, Plasma 5.23.5
  • Heroic Version [e. g. 2.1.1]: 2.4.3

Additional information

I haven't seen this kind of broken unicode in other Heroic error messages, but I haven't seen many so far.

@redromnon redromnon added the bug:confirmed Something isn't working. label Oct 5, 2022
@redromnon redromnon self-assigned this Oct 6, 2022
@redromnon
Copy link
Collaborator

Closing issue since the above PR fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:confirmed Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants