-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heroic throwing error dialog after login epic. #2590
Comments
It's the copyright sign in utf-8 |
Does the error exist if you enable utf8 support on windows? |
Hello, I have the exact same problem on a steam deck on SteamOS Beta. |
Haven't try yet. However in my memory(when messing with virtual machine before, also chinese locale) turn on this will make half of the applications we normally use show garbaged text and even crash. I don't have vm currently and better not try this on host. FYI:It looks like it's python's old school decision to use GBK on chinese locale and it's indepent of OS. While Windows' terminal defaults to so-called "gbk codepage",it does support output utf8 characters,the gbk is simply misleading but python does take this. |
If you sure that it's python's default encoders' issue,then just fork lengendary and pick my commit and then replace the bundles binary with your compiled one. |
I'm sorry, i don't understand what you are telling me. (english is not my main language and its a bit technical for me) Legendary (Epic Games)
|
Forcing change chinese encoding in Legendary won't fix the problem, because it's not limited to chinese. What we need to do is set
But I don't have js skills to do it ))) |
Turns out we can't just pass a variable and call it a day, we need Legendary to fix things. I created a PR there for this derrod/legendary#554 |
Seems like the issue in Legendary has been closed with a commit from 4 days ago. Hoping to see this in the next release of Heroic. In the meantime, it looks like I could probably fix it by hand by inserting those few lines of code in |
you can download the binary from the Legendary repository and set it in Advanced settings in heroic so you don't have to wait for a release with that |
Ahh, it's distributed as a binary created with PyInstaller... so I'll have to build it myself until Legendary comes up with a new release. Didn't find instructions in the
Binary can now be found in |
You can just fork the repo then enable the github actions,then push your change. It will automatically build it for you. "Everyone should check the .github directory and see what it actually contains" In your case,you check the workflow file to see how developer build it actually. |
you don't need to build it yourself, each commit builds the binary for all systems https://github.com/derrod/legendary/actions/runs/5101018370 |
Ahh, thanks. I must have missed that, sorry. |
Closing this since it is a Legendary issue. |
So is Heroic using Legendary snapshots? Or does there need to be a new Legendary release with the fix (which then presumably also needs to be picked up by Heroic)? |
I'm having the same error on Steam Deck. |
This will be fixed later in legendary upstream. |
Sorry for spamming, but legendary has new release version which includes a fix for this bug. |
Next release should have up to date legendary |
Consider lock the issue if spamming keeps happening. |
I have the same issue on Nobara linux |
Step 1Download the latest legendary release file Step 2Overwrite the downloaded If nothing else, this should solve your problem! |
any solution for ubuntu 23?? |
what's the exact error you are getting? |
I tried installing older legendary versions and nothing work :( |
that's a different problem than the one from this thread Do this:
if it still doesn't work, join our discord and start a thread in |
Ok thank u so much, and sorry sorry for the confuse. I'm totally noob with Heroic 🙏🏼 |
Describe the bug
A dismissable error dialog was displayed with stop windows sound after logged in to epic account.
Add logs
Steps to reproduce
1.login to epic
2.switch to other page
3.switch to login page again and dialog shows up(if not,try login with gog or switch to other random page will also trigger this)
Expected behavior
No such error dialog should show up
Screenshots
Heroic Version
main branch from GitHub
System Information
Windows 10 22h2
Additional information
version commit id be6945d
Looks like a problem of legendary?Or is some changes are not compatible with chinese languange?
The text was updated successfully, but these errors were encountered: