Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RetroWrite does not disassemble a set of functions #35

Open
miksh opened this issue May 9, 2022 · 0 comments
Open

[BUG] RetroWrite does not disassemble a set of functions #35

miksh opened this issue May 9, 2022 · 0 comments
Labels
analysis-needed This issue needs analysis and possible research to solve. bug Something isn't working

Comments

@miksh
Copy link

miksh commented May 9, 2022

RetroWrite does not disassemble certain functions
especially when their symbol visibilities are 'STV_HIDDEN.'
Moreover, the omission causes recompilation errors.

I examined source code, and found the following code that filters out hidden functions.

for symbol in section.iter_symbols():
if symbol['st_other']['visibility'] == "STV_HIDDEN":
continue

I think the above code should be removed to fix the bug.
Thank you.

Test Environment.

  1. Platform: Ubuntu 18.04, x86-64
  2. Compiler: gcc-7
  3. Target binary: binutils-2.31.1/objcopy
@miksh miksh added analysis-needed This issue needs analysis and possible research to solve. bug Something isn't working labels May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis-needed This issue needs analysis and possible research to solve. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant