Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Добавить предупредительные сообщения на ошибки #51

Closed
acidmaksim opened this issue Nov 10, 2022 · 5 comments · Fixed by #192
Closed

Добавить предупредительные сообщения на ошибки #51

acidmaksim opened this issue Nov 10, 2022 · 5 comments · Fixed by #192
Labels
enhancement New feature or request frontend The task is related to the frontend good first issue Good for newcomers Priority: High Urgent task

Comments

@acidmaksim
Copy link
Contributor

acidmaksim commented Nov 10, 2022 •
edited

Проблема:

В нашем проекте нет заглушек на ошибки, например на 404.

Какие шаги нужно воспроизвести:

  1. Ввести неккоректный Url - https://runit.hexlet.ru/hello
  2. Увидим просто надпись "Страница не найдена"

Как это сейчас:

image

Как это должно работать:
Должна выводится информация об ошибке и действия по ее устранению.
Для примера можно взять https://ru.hexlet.io/mywef

Вставить "с главной" ссылку на https://runit.hexlet.ru/
В "в поддержку" вставить email runit@hexlet.io
image
@acidmaksim acidmaksim added enhancement New feature or request good first issue Good for newcomers frontend The task is related to the frontend Priority: High Urgent task labels Nov 10, 2022
@Wenn911
Copy link
Contributor

Wenn911 commented Nov 10, 2022

Возьму в работу

@Wenn911
Copy link
Contributor

Wenn911 commented Nov 13, 2022

Какие ошибки ещё стоит добавить? 404 готова, ошибки авторизации тоже сделаны, 401 тоже есть.

@acidmaksim
Copy link
Contributor Author

@Wenn911 Добавил?

@acidmaksim
Copy link
Contributor Author

Задача свободна

@acidmaksim acidmaksim changed the title Add error messages 404 and others Добавить предупредительные сообщения на ошибки Feb 1, 2023
@seregad544
Copy link
Contributor

взял задачу

seregad544 added a commit to seregad544/runit that referenced this issue Feb 3, 2023
@seregad544
[hexlet-rus#51] added NotFoundPage
954507f
fey added a commit that referenced this issue Feb 8, 2023
@fey
Merge pull request #192 from seregad544/not_found
8ebe7f0 
[#51] added NotFoundPage
@seregad544 seregad544 mentioned this issue Feb 8, 2023
Merged
@fey fey linked a pull request Feb 10, 2023 that will close this issue
[#51] added NotFoundPage #192
Merged
@fey fey closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request frontend The task is related to the frontend good first issue Good for newcomers Priority: High Urgent task
Projects
Runit
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#51] added NotFoundPage seregad544/runit
4 participants
@fey @acidmaksim @Wenn911 @seregad544