-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in file structure are needed #18
Comments
This change will be also useful for #7 |
Good idea, but how would this work with the already existing .nbs files? Making big changes to the file format is risky :/ |
You can set two first bytes (short with |
Sure, but the older versions don't know that. This will make the new .nbs files incompatible with older versions of Note Block Studio. Is this something we really want? |
There are two options:
The problem is that when you take .nbs file generated with Note Block Studio using version 1.12 with custom instruments and open it in actual version, custom instruments are changed to regular 1.14 note blocks. If you know about different way to solve this without changing file structure, it will be better. But I don't. |
First one sounds preferable. I'll work on it :) |
Hi!
There is big issue in current .nbs file format structure. As new instruments are comming to Minecraft the index of first custom instrument changes. There is the problem:
When you open .nbs file with custom instruments from older version in new version. Custom instruments are changed to regular instruments in new version.
Suggested solution: Add structure version info to first bytes of header and first custom instrument index information near custom instruments count. This way it will be easy for parser to recognize old files and determine from which version the file comes.
The text was updated successfully, but these errors were encountered: