Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide to what degree to automatically change ndim in operations #17

Closed
HighDiceRoller opened this issue Apr 29, 2022 · 3 comments
Closed

Decide to what degree to automatically change ndim in operations #17

HighDiceRoller opened this issue Apr 29, 2022 · 3 comments

Comments

@HighDiceRoller
Copy link
Owner

HighDiceRoller commented Apr 29, 2022 •
edited

Recent changes make die arguments to Die() able to change their ndim. Should this be allowed?
@HighDiceRoller
Copy link
Owner Author

I'm leaning towards not automatically changing ndim. So far I've not needed to change it, and it may hide bugs.

@HighDiceRoller
Copy link
Owner Author

Dice outside a tuple cannot change ndims. The remaining question is what to do about ndim of dice inside tuples. Only allow scalar?

Related: #16

@HighDiceRoller
Copy link
Owner Author

Decided to disallow vector dice inside tuple outcomes.

@HighDiceRoller HighDiceRoller mentioned this issue May 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HighDiceRoller