Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Connector Not Connecting North/South wise #334

Open
acaisia opened this issue May 30, 2016 · 5 comments
Open

Map Connector Not Connecting North/South wise #334

acaisia opened this issue May 30, 2016 · 5 comments

Comments

@acaisia
Copy link

acaisia commented May 30, 2016

So I managed to connect my maps going left to right, or west to east. But when I wanted to connect colombia to peru (North to South) it did not work. I have tried note tag combinations for the two maps and nothing has worked.

@HimeWorks
Copy link
Member

What are your note-tags?
You would need to set the y-offset to "h" if you want to put another map below the current map.

@acaisia
Copy link
Author

acaisia commented Jun 3, 2016

thank you for the reply Hime, I feel so privelaged to be speaking to a legend :D

I managed to find the solution. I wasn't reading the instructions thuroughly enough. I cannot connect the map to the left or above. However reading the script I am at a loss as to why that is :P

I did purchase Effectus Optimization script and it causes errors with Area Maps and Connected Maps causes problems as well. But I hear the author of that script is no longer reachable, so I may not be able to have a working solution any time soon, and my one friend helping me with my game scripts doesn't want to help with premade scripts, only with creating scripts I can't find.

@HimeWorks
Copy link
Member

Maps are built from top-left to bottom-right. I didn't write code to support negative offsets.

@acaisia
Copy link
Author

acaisia commented Jun 4, 2016

how could I write such a code? or may I request it as a feature?

@HimeWorks
Copy link
Member

HimeWorks commented Jun 4, 2016

I don't think the code is written as nice as it could, but currently, the approach is

1. Starting from the current map, check for its connections
2. build the new map.

Which is ok, except it only supports positive offsets (ie: right or below)

Now, if you wanted to support negative offsets, you would need to do something extra

1. Starting from the current map, check for its connections
2. Sort maps based on offset lowest to highest. Your upper-left map should be the one with the smallest x/y offset
3. Build the new map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants