feat: CodeGeneratorのentryPointに直接OpenApi.Documentを指定可能にする #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Himenon
reviewed
Dec 6, 2021
Himenon
reviewed
Dec 6, 2021
| constructor(private readonly entryPoint: string, private option?: Option) { | ||
| this.rootSchema = Api.FileSystem.loadJsonOrYaml(entryPoint); | ||
| this.resolvedReferenceDocument = Api.ResolveReference.resolve(entryPoint, entryPoint, JSON.parse(JSON.stringify(this.rootSchema))); | ||
| constructor(private readonly entryPointOrDocument: string | Types.OpenApi.Document, private option?: Option) { |
tkow
force-pushed
the
feat/accept-json-format
branch
from
c660039
to
3f9de3a
Compare
tkow
changed the title
Himenon
reviewed
Dec 6, 2021
| apiClientGeneratorTemplate, | ||
| ]); | ||
|
|
||
| expect(code).toMatchSnapshot(); |
tkow
force-pushed
the
feat/accept-json-format
branch
from
8f77c93
to
e5755e9
Compare
Himenon
reviewed
Dec 6, 2021
| apiClientGeneratorTemplate, | ||
| ]); | ||
|
|
||
| expect(code1).toBe(code2); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Nest.jsなどのspec json生成ツールと連携を簡単にするために、ファイル出力をせずにjsonフォーマットを直接受け入れられるようにしました。
server reload時の自動クライアント生成などを行うユースケースに有用です。
Test Plan