Support array literals in #each
blocks
#50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48.
I failed to find a comprehensive spec for
#each
, but experimentation in the REPL shows that it can take any sort of array literal, any sort of string, or a single identifier. (There may be more valid input, but someone else can explore those edge cases.)String literals were already valid, so it was just a matter of consuming everything between balanced
[
and]
. (Just for#each
, though; array literals are not valid in#await
.)Originally I had it so that the calls to
scan_for_balanced_character
would inspect the returned boolean andreturn false
themselves if they got afalse
value — i.e., bailing early from a catastrophic parsing failure instead of proceeding to the end of the file. But this broke the test case inrandom.txt
, so I reverted that change.