Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move isLast argument in step handler handleStep method to a separate method #146

Closed
maisonobe opened this issue Jul 7, 2021 · 0 comments
Assignees

Comments

@maisonobe
Copy link
Contributor

The ODEStepHandler (and its field counterpart) declare two methods:

  • void init(ODEStateAndDerivative initialState, double finalTime)
  • void handleStep(ODEStateInterpolator interpolator, boolean isLast)

The isLast parameter in the handleStep method is set to false throughout integration except at
last step, where it is set to true.

For both simplification and symmetry with respect to the init method, this parameter should be removed from the handleStep signature and a separate void finish(ODEStateAndDerivative finalState) should be set up, with a default implementation doing nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant