Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom dataset #28

Merged
merged 3 commits into from Jul 27, 2020
Merged

Support custom dataset #28

merged 3 commits into from Jul 27, 2020

Conversation

zlapp
Copy link
Contributor

@zlapp zlapp commented Jul 27, 2020

Hi,

I wanted to test out simclr and supcontrast on custom datasets and see how they perform.
In the PR I made minimal changes to support passing in a path to the dataset, mean, and std to initialize a PyTorch ImageFolder dataset.

Thanks
@zlapp

@HobbitLong
Copy link
Owner

Thanks @zlapp very much for your contribution.

One question before merging it, do you assume images in the dataset also to be resized to 32?

@zlapp
Copy link
Contributor Author

zlapp commented Jul 27, 2020

My pleasure @HobbitLong.
Was debating what the correct approach is.
Do you think that the correct approach is to make the resize dim configurable here?:
https://github.com/zlapp/SupContrast/blob/5406a1cc8a41dc5d7cf5e9332d794b18a300836e/main_supcon.py#L146

@zlapp
Copy link
Contributor Author

zlapp commented Jul 27, 2020

Added size as an argument with default of 32

@HobbitLong HobbitLong merged commit 8117ece into HobbitLong:master Jul 27, 2020
@HobbitLong
Copy link
Owner

LGTM, thank you very much! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants