Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Migrate from artifacts to the new altool #719

Open
Arthurvdv opened this issue Jan 29, 2024 · 1 comment
Open

[FEATURE REQUEST] Migrate from artifacts to the new altool #719

Arthurvdv opened this issue Jan 29, 2024 · 1 comment

Comments

@Arthurvdv
Copy link

Is your feature request related to a problem? Please describe.
We're using Microsoft-hosted agents for release pipelines (ALOpsExtensionAPI@1).
Currently every run will install the BcContainerHelper and then download the BC-Artifacts.

2024-01-19T10:32:50.9832954Z *** Import NAV/BC Management DLL's [False]
2024-01-19T10:32:51.0162786Z *** ServiceTier not specified, loading default assemblies.
2024-01-19T10:32:51.0253705Z *** Default Assemblies not found. Load via BC-Artifacts
2024-01-19T10:32:51.0411958Z *** Install/Update BCContainerHelper [https://github.com/microsoft/navcontainerhelper]
2024-01-19T10:32:51.0452958Z *** Check BcContainerHelper
2024-01-19T10:34:55.7514703Z *** Install BcContainerHelper
2024-01-19T10:35:20.1595793Z *** Load BcContainerHelper
2024-01-19T10:35:20.4743248Z BcContainerHelper version 6.0.3
2024-01-19T10:35:21.1853816Z BC.HelperFunctions emits usage statistics telemetry to Microsoft
2024-01-19T10:35:24.0771596Z 
2024-01-19T10:35:24.0772498Z ModuleType Version    Name                                ExportedCommands                                             
2024-01-19T10:35:24.0773669Z ---------- -------    ----                                ----------------                                             
2024-01-19T10:35:24.0777376Z Script     6.0.3      BcContainerHelper                   {Add-FontsToBcContainer, Add-GitToAlProjectFolder, AddTele...
2024-01-19T10:35:24.0777659Z 
2024-01-19T10:35:24.0777828Z 
2024-01-19T10:35:24.0777995Z 
2024-01-19T10:35:24.0779925Z 
2024-01-19T10:35:24.0806049Z ##[command]"Get-BCArtifactUrl" 
2024-01-19T10:35:24.0806356Z Name                           Value                                                                                   
2024-01-19T10:35:24.0806716Z ----                           -----                                                                                   
2024-01-19T10:35:24.0807273Z select                         Latest                                                                                  
2024-01-19T10:35:24.0807603Z type                           OnPrem                                                                                  
2024-01-19T10:35:24.0807935Z country                        W1                                                                                      
2024-01-19T10:35:24.0808119Z 
2024-01-19T10:35:24.0808318Z 
2024-01-19T10:35:24.0808807Z  -select: Latest -type: OnPrem -country: W1
2024-01-19T10:35:26.8367528Z Downloading artifact /onprem/23.3.14876.15024/w1
2024-01-19T10:35:26.8719007Z Downloading C:\Users\VssAdministrator\AppData\Local\Temp\dee5cf3e-756b-439f-b721-aa8b8cf2612a.zip
2024-01-19T10:35:26.8774867Z Downloading using WebClient
2024-01-19T10:35:30.9580511Z Unpacking artifact to tmp folder using 7zip
2024-01-19T10:35:34.6526305Z Downloading platform artifact /onprem/23.3.14876.15024/platform
2024-01-19T10:35:34.6559499Z Downloading C:\Users\VssAdministrator\AppData\Local\Temp\a5f2e073-ef18-46e8-87a0-ec0604a53d4b.zip
2024-01-19T10:35:34.6573206Z Downloading using WebClient
2024-01-19T10:35:58.0574902Z Unpacking platform artifact to tmp folder using 7zip
2024-01-19T10:36:26.4983253Z Downloading Prerequisite Components
2024-01-19T10:36:27.2093153Z Downloading C:\bcartifacts.cache\onprem\23.3.14876.15024\platform\Prerequisite Components\DotNetCore\DotNetCore.1.0.4_1.1.1-WindowsHosting.exe
2024-01-19T10:36:27.2099109Z Downloading using WebClient
2024-01-19T10:36:29.5294972Z Downloading C:\bcartifacts.cache\onprem\23.3.14876.15024\platform\Prerequisite Components\IIS URL Rewrite Module\rewrite_2.0_rtw_x64.msi
2024-01-19T10:36:29.5306182Z Downloading using WebClient
2024-01-19T10:36:30.1263205Z *** Platform: C:\bcartifacts.cache\onprem\23.3.14876.15024\platform
2024-01-19T10:36:30.1295436Z *** Localisation: C:\bcartifacts.cache\onprem\23.3.14876.15024\w1
2024-01-19T10:36:30.2163714Z *** BC Management DLL: C:\bcartifacts.cache\onprem\23.3.14876.15024\platform\ServiceTier\program files\Microsoft Dynamics NAV\230\Service\Management\Microsoft.Dynamics.Nav.Management.dll
2024-01-19T10:36:30.2274456Z *** Selected module: [C:\bcartifacts.cache\onprem\23.3.14876.15024\platform\ServiceTier\program files\Microsoft Dynamics NAV\230\Service\Management\Microsoft.Dynamics.Nav.Management.dll]
2024-01-19T10:36:30.2283022Z *** Loading module: [C:\bcartifacts.cache\onprem\23.3.14876.15024\platform\ServiceTier\program files\Microsoft Dynamics NAV\230\Service\Management\Microsoft.Dynamics.Nav.Management.dll]
2024-01-19T10:36:30.3460883Z *** BC App Management DLL: C:\bcartifacts.cache\onprem\23.3.14876.15024\platform\ServiceTier\program files\Microsoft Dynamics NAV\230\Service\Management\Microsoft.Dynamics.Nav.Apps.Management.dll
2024-01-19T10:36:30.3478293Z *** Selected module: [C:\bcartifacts.cache\onprem\23.3.14876.15024\platform\ServiceTier\program files\Microsoft Dynamics NAV\230\Service\Management\Microsoft.Dynamics.Nav.Apps.Management.dll]
2024-01-19T10:36:30.3486940Z *** Loading module: [C:\bcartifacts.cache\onprem\23.3.14876.15024\platform\ServiceTier\program files\Microsoft Dynamics NAV\230\Service\Management\Microsoft.Dynamics.Nav.Apps.Management.dll]

Describe the solution you'd like
Migrate from importing the .dll files from the artifacts, to the new altool which come with the AL Language extension version 13.0.

I believe this will bring multiple benefits

  • Improve stability (prevent breaking on breaking changes in artifacts)
  • Prevent possible refactoring in the future when the artifacts are replaced with NuGet feeds
  • Improve duration when Default Assemblies not found. Load via BC-Artifacts. is needed. This will take up to almost 4min. Downloading the AL Language extension and grabbing the altool could be faster I believe.
  • No longer dependent on the BCContainerHelper
  • Enable the ALOpsExtensionAPI to run with a vmImage: 'ubuntu-latest' Microsoft-hosted agent (there's a Windows and Linux binary available)

To support a gradual transition it would be helpful If we could switch between the current implementation and the new altool. Ideally a ALOpsExtensionAPI@2 step, but a flag/setting on the current ALOpsExtensionAPI@1 also could suffice. Not sure what is most feasible to create, and we should leave the implementation details to you of course :-)

Additional context
image

@waldo1001
Copy link
Collaborator

waldo1001 commented Mar 5, 2024

#726 made us switch for CompilerV2 - but it will need to rework for the other tasks ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants