changes memlimit to interactive #6
Conversation
There was a problem hiding this comment.
@willemolding - can you expose the opt to the caller and have it still default to sensitive?
also, does moderate work without errors?
|
So it looks like MODERATE works fine. It takes around 2.5 seconds to hash a password. I guess the purpose of this PR is to establish if we definitely need the SENSITIVE variant and in that case how to figure out the root of the problem, or if a less memory intensive variant is ok for the closed alpha. I'm not sure if it makes sense to let the calling code decide this if it leads to insecure password hashing. What are your thoughts @neonphog ? |
|
@willemolding I think MODERATE should be ok for the MEM for the Holo use-case (especially for closed alpha) so long as we keep the cpu limit at SENSITIVE. We're a little constrained by the wasm heap as far as memory goes, and I don't think it's worth mucking with that. |
Closes #4
I was previously getting around this with a git patch but I see the need to make this module npm install-able soon.
The errors returned by libsodium are very unhelpful so I have no idea why it is crashing with the large memory use setting.
Would it be ok to have this setting for closed alpha or at least until we figure out why it is not working with the suggested settings?