Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace atom in utils.rb with vscodium #14776

Closed
1 task done
earthsound opened this issue Feb 23, 2023 · 0 comments · Fixed by #14779
Closed
1 task done

replace atom in utils.rb with vscodium #14776

earthsound opened this issue Feb 23, 2023 · 0 comments · Fixed by #14779
Labels
features New features outdated PR was locked due to age

Comments

@earthsound
Copy link

Verification

Provide a detailed description of the proposed feature

Currently, atom is first in the list when searching for editors in utils.rb.

# Find Atom, Sublime Text, VS Code, Textmate, BBEdit, or vim
    editor = %w[atom subl code mate bbedit vim].find do |candidate|
      candidate if which(candidate, ORIGINAL_PATHS)
    end

Since atom is deprecated and (at least on my MPB) marked as harmful (iirc due to code signature expiration) could we replace atom with codium?

What is the motivation for the feature?

Atom is deprecated and something needs to replace it.

How will the feature be relevant to at least 90% of Homebrew users?

Going with the spirit of the discussion in #2915 (pointing out why atom was added as the first option), replacing atom with an open source GUI editor seems to make the most since. VS Code is further down in the list (code), but I'm making the assumption I'm not the only one who prefers VSCodium.

What alternatives to the feature have been considered?

None.

@earthsound earthsound added the features New features label Feb 23, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
features New features outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant