Openblas failed to pour the bottle on macOS

[alazarolop]

brew gist-logs <formula> link OR brew config AND brew doctor output

Your system is ready to brew.

Verification

• My "brew doctor output" says Your system is ready to brew. and am still able to reproduce my issue.
• I ran brew update and am still able to reproduce my issue.
• I have resolved all warnings from brew doctor and that did not fix my problem.
• I searched for recent similar issues at https://github.com/Homebrew/homebrew-core/issues?q=is%3Aissue and found no duplicates.

What were you trying to do (and why)?

I have already installed the formula openblas and I wanted to upgrade it. I have seen a similar issue in another formula #15805

What happened (include all command output)?

==> Upgrading openblas
  0.3.23 -> 0.3.24

Error: Parameter 'old': Expected type Pathname, got type String with value "@@HOMEBREW_PREFIX@@/opt/gc.../gcc/x86_64-apple-darwin22/13"
Caller: /usr/local/Homebrew/Library/Homebrew/extend/os/mac/keg_relocate.rb:41
Definition: /usr/local/Homebrew/Library/Homebrew/os/mac/keg.rb:40

What did you expect to happen?

Pouring of the bottle properly.

Step-by-step reproduction instructions (by running brew commands)

brew upgrade openblas

[Bo98]

Looks like change_rpath has the wrong type signature (old and new are always String and never Pathname and ruby-macho expects Strings)

[alazarolop]

Thank you for the quick reply! Is this something I should fix in my installation or it depends on the formula?

[MikeMcQuaid]

@alazarolop Can I see your brew config output? Working on a fix, thanks.

[alazarolop]

Thank you a lot @MikeMcQuaid .

[MikeMcQuaid]

You're welcome @alazarolop!

[scpeters]

Looks like change_rpath has the wrong type signature (old and new are always String and never Pathname and ruby-macho expects Strings)

apologies, I added that in #15980 but didn't know what I was doing. It was needed for intermediate form of the pull request, but I think the type declarations aren't needed now. Should I remove the other type signatures that I added to os/mac/keg?

[MikeMcQuaid]

@scpeters No worries, it happens! I think fine to leave other signatures in unless you know them to be wrong but, lesson learned for me I guess on being wary of these sorts of changes that aren't covered by test.