Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with brew audit #15995

Closed
4 tasks done
TabulateJarl8 opened this issue Sep 11, 2023 · 1 comment · Fixed by #16000
Closed
4 tasks done

Issue with brew audit #15995

TabulateJarl8 opened this issue Sep 11, 2023 · 1 comment · Fixed by #16000
Labels
bug Reproducible Homebrew/brew bug outdated PR was locked due to age

Comments

@TabulateJarl8
Copy link

TabulateJarl8 commented Sep 11, 2023

brew gist-logs <formula> link OR brew config AND brew doctor output

`brew config`:

HOMEBREW_VERSION: 4.1.10
ORIGIN: https://github.com/Homebrew/brew
HEAD: 12c8778af976269344f3c0b914243e178fc4ffbd
Last commit: 5 days ago
Core tap origin: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 358f9b4c5f46fbfaefc1b5e052f397b55943a18f
Core tap last commit: 4 days ago
Core tap branch: master
Core tap JSON: 07 Sep 20:19 UTC
HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: :0.0
HOMEBREW_MAKE_JOBS: 4
HOMEBREW_NO_INSTALL_FROM_API: set
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 2.6.10 => /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.10_1/bin/ruby
CPU: quad-core 64-bit zen
Clang: 16.0.6
Git: 2.34.1 => /bin/git
Curl: 7.81.0 => /bin/curl
Kernel: Linux 5.15.0-83-generic x86_64 GNU/Linux
OS: Ubuntu 22.04.3 LTS (jammy)
Host glibc: 2.35
/usr/bin/gcc: 11.4.0
/usr/bin/ruby: N/A
glibc: N/A
gcc@11: N/A
gcc: N/A
xorg: N/A

`brew doctor`:
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: You have uncommitted modifications to Homebrew/homebrew-core.
If this is a surprise to you, then you should stash these modifications.
Stashing returns Homebrew to a pristine state but can be undone
should you later need to do so for some reason.
  cd /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core && git stash -u && git clean -d -f

Uncommitted files:
  ?? Formula/s/squiid.rb

Verification

  • My "brew doctor output" says Your system is ready to brew. and am still able to reproduce my issue.
  • I ran brew update and am still able to reproduce my issue.
  • I have resolved all warnings from brew doctor and that did not fix my problem.
  • I searched for recent similar issues at https://github.com/Homebrew/homebrew-core/issues?q=is%3Aissue and found no duplicates.

What were you trying to do (and why)?

I'm trying to audit my package for submission, but brew audit seems to be giving an error

What happened (include all command output)?

It doesn't error when HOMEBREW_NO_INSTALL_FROM_API isn't set, but when it is, I get the following output on macOS, Linux, and the build CI:

user@hostname:~$ HOMEBREW_NO_INSTALL_FROM_API=1 brew audit --new-formula squiid
 
Error: undefined method `<' for nil:NilClass
Please report this issue:
  https://docs.brew.sh/Troubleshooting
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/utils/shared_audits.rb:116:in `gitlab'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_auditor.rb:613:in `audit_gitlab_repository'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_auditor.rb:914:in `block in audit'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_auditor.rb:909:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_auditor.rb:909:in `audit'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/audit.rb:213:in `tap'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/audit.rb:213:in `block (4 levels) in audit'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/api.rb:192:in `with_no_api_env'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:89:in `block in create_validator_slow'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/audit.rb:218:in `block (3 levels) in audit'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/simulate_system.rb:29:in `with'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/_methods.rb:270:in `block in _on_method_added'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/audit.rb:208:in `block (2 levels) in audit'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/audit.rb:207:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/audit.rb:207:in `flat_map'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/audit.rb:207:in `block in audit'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/audit.rb:190:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/audit.rb:190:in `each_with_object'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/audit.rb:190:in `audit'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/_methods.rb:270:in `block in _on_method_added'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:94:in `<main>'

What did you expect to happen?

brew audit to pass successfully. PR is Homebrew/homebrew-core#141733

Step-by-step reproduction instructions (by running brew commands)

HOMEBREW_NO_INSTALL_FROM_API=1 brew audit --new-formula squiid
@TabulateJarl8 TabulateJarl8 added the bug Reproducible Homebrew/brew bug label Sep 11, 2023
@SMillerDev SMillerDev transferred this issue from Homebrew/homebrew-core Sep 12, 2023
@alebcay
Copy link
Member

alebcay commented Sep 12, 2023

The issue here is that https://gitlab.com/ImaginaryInfinity/squiid-calculator is a group, but this audit is expecting it to be a project repo (the actual project is at https://gitlab.com/ImaginaryInfinity/squiid-calculator/squiid).

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Reproducible Homebrew/brew bug outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants