Commands may have broken args

[Rylan12]

#8144 has caused several issues where arguments not working correctly. I'm opening this issue as a way to track these in one place

As I check each command to make sure the arguments work correctly, I'll mark it below. Note that if a command is unchecked it isn't necessarily broken, I just haven't checked it.

If anyone from the community wasn't to help go through these please do; there are a lot 😅

Built In Commands

• --cache.rb
• --cellar.rb
• --env.rb
• --prefix.rb
• --repository.rb
• --version.rb
• analytics.rb
• cask.rb
• cleanup.rb
• commands.rb
• config.rb
• deps.rb - deps: fix args #8174
• desc.rb
• doctor.rb
• fetch.rb
• gist-logs.rb
• help.rb
• home.rb
• info.rb
• install.rb - Arg fixes #8172
• leaves.rb
• link.rb
• list.rb
• log.rb
• migrate.rb
• missing.rb
• options.rb
• outdated.rb - outdated: fix args #8175
• pin.rb
• postinstall.rb
• readall.rb
• reinstall.rb
• search.rb
• switch.rb
• tap-info.rb
• tap.rb
• uninstall.rb
• unlink.rb
• unpin.rb
• untap.rb
• update-report.rb - update-report: fix args #8176
• upgrade.rb
• uses.rb

Developer Commands

• audit.rb
• bottle.rb - bottle: fix args #8178
• bump-formula-pr.rb
• bump-revision.rb
• cat.rb
• command.rb
• create.rb
• diy.rb
• edit.rb
• extract.rb
• formula.rb
• install-bundler-gems.rb
• irb.rb
• linkage.rb
• man.rb
• mirror.rb
• pr-automerge.rb
• pr-publish.rb
• pr-pull.rb
• pr-upload.rb
• prof.rb
• pull.rb
• release-notes.rb
• ruby.rb
• sh.rb
• sponsors.rb
• style.rb
• tap-new.rb
• test.rb
• tests.rb
• unpack.rb
• update-license-data.rb
• update-python-resources.rb
• update-test.rb
• vendor-gems.rb

[Rylan12]

It's worth pointing out my process here:

I looked in every command file to find instances where args were referenced without either: 1. being in the main method for the command or 2. being in a separate method that had didn't have args passed as a parameter.

For example:

def foo
  do_something if args.verbose?
end

should become

def foo(args:)
  do_something if args.verbose?
end

And would be called by:

foo(args: args)

---

I did not try every flag in every command so it's possible that there are instances where the command calls code in another module that is broken as a result of the args changes.

[reitermarkus]

Thanks, @Rylan12!