Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some tests! #6

Closed
andrew opened this issue Jan 23, 2013 · 6 comments
Closed

Add some tests! #6

andrew opened this issue Jan 23, 2013 · 6 comments
Labels
outdated

Comments

@andrew
Copy link
Contributor

andrew commented Jan 23, 2013

No description provided.

@ghost ghost assigned jamesaanderson Jun 11, 2013
@jamesaanderson jamesaanderson mentioned this issue Jun 13, 2013
Closed
@jamesaanderson
Copy link
Contributor

83.33% test coverage. Hoping to raise it to 90+% before I close.

@andrew
Copy link
Contributor Author

andrew commented Jun 14, 2013

👍

@jamesaanderson
Copy link
Contributor

Update: I've raised the test coverage to 92.45% but need to refactor several specs before I push.

@jamesaanderson
Copy link
Contributor

Closing. Locally it says the test coverage is at 95.74% but Coveralls is showing 81%. Investigating Travis's build error now.

@jamesaanderson
Copy link
Contributor

@andrew Can you try running my latest commit's tests locally? Does it error out for you and what coverage % does it give you?

@jamesaanderson
Copy link
Contributor

Moving the discussion to #14

@lock lock bot added the outdated label Jan 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrew @jamesaanderson