Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jbrowse 2.12.2 #177592

Merged
merged 1 commit into from
Jun 24, 2024
Merged

jbrowse 2.12.2 #177592

merged 1 commit into from
Jun 24, 2024

Conversation

khipp
Copy link
Contributor

@khipp khipp commented Jun 23, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@BrewTestBot BrewTestBot added the missing zap Cask is missing a zap stanza, please add one. label Jun 23, 2024
@reitermarkus
Copy link
Member

The default git strategy seems to work fine, no?

@khipp
Copy link
Contributor Author

khipp commented Jun 23, 2024

Maybe I missed something, but when checking for outdated casks, I got the result 1.16.11 ==> 1.16.11-release.

@bevanjkay
Copy link
Member

It should only require updating the repo url, but the livecheck block isn't necessary.

@khipp khipp changed the title jbrowse: add livecheck jbrowse 2.12.2 Jun 23, 2024
@BrewTestBot BrewTestBot removed the missing zap Cask is missing a zap stanza, please add one. label Jun 23, 2024
@khipp
Copy link
Contributor Author

khipp commented Jun 23, 2024

When I remove

  livecheck do
    url :url
    strategy :github_latest
  end

I get the following output:

❯ brew livecheck --debug jbrowse                                                                                                                                                                        (torch) 
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::NullLoader): loading jbrowse
/opt/homebrew/Library/Homebrew/brew.rb (Cask::CaskLoader::FromNameLoader): loading jbrowse

Cask:             jbrowse
Livecheckable?:   No

URL:              https://github.com/GMOD/jbrowse-components/releases/download/v2.12.2/jbrowse-desktop-v2.12.2-mac.dmg
URL (processed):  https://github.com/GMOD/jbrowse-components.git
Strategy:         Git

Matched Versions:
0.0.1-testrelease.1, 0.0.1-testrelease.2, 1.0.0, 3@1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.1.0, 1.2.0, 1.3.0, 1.3.1, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.5.5, 1.5.6, 1.5.7, 1.5.8, 1.5.9, 1.6.0, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.6.6, 1.6.7, 1.6.8, 1.6.9, 1.7.0, 1.7.1, 1.7.10, 1.7.11, 1.7.2, 1.7.3, 1.7.4, 1.7.5, 1.7.6, 1.7.7, 1.7.8, 1.7.9, 2.0.0, 2.0.1, 2.1.0, 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.1.5, 2.1.6, 2.1.7, 2.10.0, 2.10.1, 2.10.2, 2.10.3, 2.11.0, 2.11.1, 2.11.2, 2.12.0, 2.12.1, 2.12.2, 2.2.0, 2.2.1, 2.2.2, 2.3.0, 2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.4.0, 2.4.1, 2.4.2, 2.5.0, 2.6.1, 2.6.2, 2.6.3, 2.7.0, 2.7.1, 2.7.2, 2.8.0, 2.9.0

jbrowse: 2.12.2 ==> 3@1.0.0

I would require some assistance if there is a better way without requiring the extra livecheck.

Casks/j/jbrowse.rb Outdated Show resolved Hide resolved
Casks/j/jbrowse.rb Outdated Show resolved Hide resolved
@razvanazamfirei razvanazamfirei merged commit f1397cf into Homebrew:master Jun 24, 2024
9 checks passed
@khipp khipp deleted the update-jbrowse branch June 24, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants