-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent homebrew cask to report updates when it's only linting changes #87343
Comments
Linting changes aren’t common. This isn’t an issue. Other changes may indeed be relevant even if the version doesn’t change, so they’re useful to see. |
@vitorgalvao Imho, zap updates for example aren't worth notifying an update, which result in user running a |
I still don’t think this affects (bothers) enough users to warrant the change. That said, I also think this affects both formulae and casks, as you mention above, meaning it should be reported on Homebrew/brew, which you may want to try (note that repo has a different template that needs to be filled). |
It doesn't, actually. Formulae only are reported as "updated" here when the version changes and, when we don't calculate version changes (for performance reasons), we don't show any as "updated". This could (and probably should) be behaviour we adopt for casks? |
This probably happens much less often, but I believe that it happened fore core a couple of days/weeks ago with a big commit that happened. I might be wrong, and have bad memories though.
For my information, can you give an example of what can this be? |
Whenever |
Oh, so one can miss updates in such cases? Damn, didn't knew this changed. I thought it was still reporting applications that could be updated. |
For future reference: Homebrew/brew#8395 |
This just happened again with #87436 : massive amount of updates reported, including most if not all of the installed casks, while no versions changed at all. |
I was also annoyed by this so opened Homebrew/brew#8693 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@miccal Is this solved? Can it be closed? |
No I have not done this yet -- it was not as straight-forward as I initially thought, and I have not yet had the time to investigate this further. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Issue's still here, especially now we got all the updates report just because of the livecheck addition. Or some description edits. |
The point of the bot is not to find issues we forgot to close after fixing; it’s to point out issues with no momentum. Bottom line, this isn’t a bug but a small inconvenience that’s low on the list of maintainer priorities. If, at the same time, no outside contributed cares enough about this to fix it, it does us no good to keep it open (quite the contrary, it just makes other issues harder to find). |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
General troubleshooting steps
--force
.brew update-reset && brew update
and retried my command.brew doctor
, fixed as many issues as possible and retried my command.Description of issue
First of all I'm not aware enough if the issue is about casks only of should be reported in anther more general repository for the whole Homebrew, though I think casks have more often a special versioning and oftentimes does not automatically update as it consider getting updates from the app itself.
When updating homebrew, casks are often reported as having an update, but there's nothing to update on the upgrade we can try after.
This is generally due to linting changes, like #87307 or another big one we got in the past weeks I don't find back right now, or due to changes on rules like zap one.
It would be quite useful to not report update on applications for this kind of changes, if this is possible.
The text was updated successfully, but these errors were encountered: