Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent homebrew cask to report updates when it's only linting changes #87343

Closed
6 tasks done
Porkepix opened this issue Aug 10, 2020 · 18 comments
Closed
6 tasks done

Prevent homebrew cask to report updates when it's only linting changes #87343

Porkepix opened this issue Aug 10, 2020 · 18 comments
Labels
outdated stale Issue which has not received any feedback for some time.

Comments

@Porkepix
Copy link
Contributor

General troubleshooting steps

Description of issue

First of all I'm not aware enough if the issue is about casks only of should be reported in anther more general repository for the whole Homebrew, though I think casks have more often a special versioning and oftentimes does not automatically update as it consider getting updates from the app itself.

When updating homebrew, casks are often reported as having an update, but there's nothing to update on the upgrade we can try after.

This is generally due to linting changes, like #87307 or another big one we got in the past weeks I don't find back right now, or due to changes on rules like zap one.

It would be quite useful to not report update on applications for this kind of changes, if this is possible.

@vitorgalvao
Copy link
Member

Linting changes aren’t common. This isn’t an issue.

Other changes may indeed be relevant even if the version doesn’t change, so they’re useful to see.

@Porkepix
Copy link
Contributor Author

Porkepix commented Aug 10, 2020

@vitorgalvao Imho, zap updates for example aren't worth notifying an update, which result in user running a brew cask upgrade [formula]… to end up seeing nothing updates, because there's actually no new release, just zap or linting changes (even a simple url change display an update available during brew update!)

@vitorgalvao
Copy link
Member

I still don’t think this affects (bothers) enough users to warrant the change. That said, I also think this affects both formulae and casks, as you mention above, meaning it should be reported on Homebrew/brew, which you may want to try (note that repo has a different template that needs to be filled).

@MikeMcQuaid
Copy link
Member

I also think this affects both formulae and casks, as you mention above, meaning it should be reported on Homebrew/brew, which you may want to try (note that repo has a different template that needs to be filled).

It doesn't, actually. Formulae only are reported as "updated" here when the version changes and, when we don't calculate version changes (for performance reasons), we don't show any as "updated". This could (and probably should) be behaviour we adopt for casks?

@MikeMcQuaid MikeMcQuaid reopened this Aug 11, 2020
@Porkepix
Copy link
Contributor Author

It doesn't, actually. Formulae only are reported as "updated" here when the version changes

This probably happens much less often, but I believe that it happened fore core a couple of days/weeks ago with a big commit that happened. I might be wrong, and have bad memories though.

and, when we don't calculate version changes (for performance reasons)

For my information, can you give an example of what can this be?

@MikeMcQuaid
Copy link
Member

For my information, can you give an example of what can this be?

Whenever brew update is run as an autoupdate i.e. before a brew install.

@Porkepix
Copy link
Contributor Author

For my information, can you give an example of what can this be?

Whenever brew update is run as an autoupdate i.e. before a brew install.

Oh, so one can miss updates in such cases? Damn, didn't knew this changed. I thought it was still reporting applications that could be updated.

@miccal
Copy link
Member

miccal commented Aug 19, 2020

For future reference: Homebrew/brew#8395

@Porkepix
Copy link
Contributor Author

Porkepix commented Sep 11, 2020

This just happened again with #87436 : massive amount of updates reported, including most if not all of the installed casks, while no versions changed at all.

@MikeMcQuaid
Copy link
Member

I was also annoyed by this so opened Homebrew/brew#8693

@BrewTestBot
Copy link
Member

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added the stale Issue which has not received any feedback for some time. label Dec 12, 2020
@vitorgalvao
Copy link
Member

@miccal Is this solved? Can it be closed?

@miccal
Copy link
Member

miccal commented Dec 12, 2020

@miccal Is this solved? Can it be closed?

No I have not done this yet -- it was not as straight-forward as I initially thought, and I have not yet had the time to investigate this further.

@BrewTestBot BrewTestBot removed the stale Issue which has not received any feedback for some time. label Dec 12, 2020
@BrewTestBot
Copy link
Member

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added stale Issue which has not received any feedback for some time. and removed stale Issue which has not received any feedback for some time. labels Jan 3, 2021
@BrewTestBot
Copy link
Member

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added the stale Issue which has not received any feedback for some time. label Jan 25, 2021
@Porkepix
Copy link
Contributor Author

Issue's still here, especially now we got all the updates report just because of the livecheck addition. Or some description edits.

@BrewTestBot BrewTestBot removed the stale Issue which has not received any feedback for some time. label Jan 25, 2021
@vitorgalvao
Copy link
Member

Issue's still here

The point of the bot is not to find issues we forgot to close after fixing; it’s to point out issues with no momentum.

Bottom line, this isn’t a bug but a small inconvenience that’s low on the list of maintainer priorities. If, at the same time, no outside contributed cares enough about this to fix it, it does us no good to keep it open (quite the contrary, it just makes other issues harder to find).

@BrewTestBot
Copy link
Member

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added the stale Issue which has not received any feedback for some time. label Feb 16, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated stale Issue which has not received any feedback for some time.
Projects
None yet
Development

No branches or pull requests

5 participants