Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brew bump-cask-pr should not add a checksum when a cask is versioned and has :no_check #94942

Closed
vitorgalvao opened this issue Dec 8, 2020 · 1 comment
Closed

brew bump-cask-pr should not add a checksum when a cask is versioned and has :no_check #94942

vitorgalvao opened this issue Dec 8, 2020 · 1 comment
Labels
outdated

Comments

@vitorgalvao
Copy link
Member

vitorgalvao commented Dec 8, 2020 •
edited

With Homebrew/brew#9423 and other changes, we’re going to have a lot of casks that have a version but sha256 :no_check. brew bump-cask-pr should be updated to handle those.

When brew bump-cask-pr is called, if the cask is NOT version :latest but IS sha256 :no_check, do not update sha256 unless the user specifically submitted one with --sha256.

Ping @reitermarkus @core-code @SeekingMeaning in case I forgot something.

@SeekingMeaning There’s this and a few other bump-cask-pr issues on this tracker. Are you available to continue the work on those? As it is, it still doesn’t replace cask-repair for most needed automation cases.
@SeekingMeaning SeekingMeaning mentioned this issue Dec 8, 2020
Closed
4 tasks
@SeekingMeaning
Copy link
Contributor

This should be fixed with brew version 2.6.2

@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@core-code @BrewTestBot @vitorgalvao @SeekingMeaning