Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong dependency relationship on HEIF support of ImageMagick #28035

Closed
hguandl opened this issue May 19, 2018 · 1 comment
Closed

Wrong dependency relationship on HEIF support of ImageMagick #28035

hguandl opened this issue May 19, 2018 · 1 comment
Labels
outdated PR was locked due to age

Comments

@hguandl
Copy link

hguandl commented May 19, 2018

In #26444 it has been reported that imagemagick can add libheif to support HEIF. A PR #26960 was also raised. But in fact, during 0d4ca9d, this issue was not solved completely.

libheif needs libde265 to decode and x265 to encode. In 0d4ca9d, only libde265 was added to the formula of imagemagick, which means the HEIF support is actually not implemented. So it's --with-libheif rather than --with-libde265 that should be added to the formula of imagemagick, and a new formula libheif should also be created.

#26960 is a usable one. The only problem is that the support for macOS was fixed after some commits of the current release. So we need to use HEAD version or just after strukturag/libheif@a237e50a.
@ilovezfs
Copy link
Contributor

And that is why #26960 remains open. In the future, please fill out the template completely.

@lock lock bot added the outdated PR was locked due to age label Jun 18, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilovezfs @hguandl