You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
are reporting a bug others will be able to reproduce and not asking a question. If you're not sure or want to ask a question do so on our Discourse: https://discourse.brew.sh
This appears to be a problem with the SDL projects, and not within Homebrew's configuration. Once a fix has been issued by upstream, we can integrated it into Homebrew (pul request welcome). That looks possible for SDL2, but SDL1 is long dead, so I am not sure how this can go there…
Yes, I'm following the issue closely and will submit a PR when a fix is available.
ps. I have a question about process around here... I think perhaps I'm confused, as other "upstream issue" breakages are left open. I thought linking to the upstream bug would be useful for people tracking to see if this has been fixed yet, and that it would reduce other people having to submit the same issue again. I know this is useful for people tracking the breakage, but if it's not something that this project wants then I won't link things up anymore. Is the difference "This appears to be a problem with the SDL projects, and not within Homebrew's configuration"? So I only submit issues that are to do with breakages if the issue is not in upstream?
pps. Probably a better word for SDL 1 is undead ;) There's an SDL 1 branch that collects fixes, and 'one' new release planned. There's more than 50k apps using SDL1... with users in the hundreds of millions(way more than homebrew).
As you say, we have to walk a fine line: we can't handle bug reports for all packages we ship, but we want to make sure a. they do not come from Homebrew packaging, b. they are reported upstream.
Basically, once a bug is identified, analysed, and reported upstream, there is not much we can do until it's fixed. Keeping all issues open would be a nightmare for us in terms of prioritising support. People can still find the issue if they search for it!
Activity
illume commentedon Oct 16, 2018
Note, this effects SDL1 and SDL2.
fxcoudert commentedon Oct 17, 2018
This appears to be a problem with the SDL projects, and not within Homebrew's configuration. Once a fix has been issued by upstream, we can integrated it into Homebrew (pul request welcome). That looks possible for SDL2, but SDL1 is long dead, so I am not sure how this can go there…
Many thanks for reporting the issue.
illume commentedon Oct 17, 2018
Yes, I'm following the issue closely and will submit a PR when a fix is available.
ps. I have a question about process around here... I think perhaps I'm confused, as other "upstream issue" breakages are left open. I thought linking to the upstream bug would be useful for people tracking to see if this has been fixed yet, and that it would reduce other people having to submit the same issue again. I know this is useful for people tracking the breakage, but if it's not something that this project wants then I won't link things up anymore. Is the difference "This appears to be a problem with the SDL projects, and not within Homebrew's configuration"? So I only submit issues that are to do with breakages if the issue is not in upstream?
pps. Probably a better word for SDL 1 is undead ;) There's an SDL 1 branch that collects fixes, and 'one' new release planned. There's more than 50k apps using SDL1... with users in the hundreds of millions(way more than homebrew).
fxcoudert commentedon Oct 17, 2018
As you say, we have to walk a fine line: we can't handle bug reports for all packages we ship, but we want to make sure a. they do not come from Homebrew packaging, b. they are reported upstream.
Basically, once a bug is identified, analysed, and reported upstream, there is not much we can do until it's fixed. Keeping all issues open would be a nightmare for us in terms of prioritising support. People can still find the issue if they search for it!
illume commentedon Oct 18, 2018
Makes sense. Thanks.
Photosounder commentedon Oct 25, 2018
SDL 1.2 is actually still maintained (see https://hg.libsdl.org/SDL/shortlog/12354) but doesn't receive official releases anymore.
Photosounder commentedon Nov 13, 2018
@illume SDL 2.0.9 has been released and fixes the problem apparently, but the formula for SDL2 still uses SDL 2.0.8 unfortunately.
fxcoudert commentedon Nov 14, 2018
@Photosounder 2.0.9 has introduced another bug: see #33578
Photosounder commentedon Nov 14, 2018
Oh, that's rather concerning, but what's the bug? All this says is "Created with brew bump-formula-pr."
fxcoudert commentedon Nov 14, 2018
Sorry wrong PR: #33781
Photosounder commentedon Nov 14, 2018
Thank you, I just filed a bug for this on the SDL bug tracker: https://bugzilla.libsdl.org/show_bug.cgi?id=4385
illume commentedon Nov 15, 2018
Here is the commit which fixes that issue: http://hg.libsdl.org/SDL/rev/d274fa9731b1
https://bugzilla.libsdl.org/show_bug.cgi?id=4367
I'm not sure when a new release is planned.
Photosounder commentedon Nov 15, 2018
Yes sadly it doesn't seem like they intend on making a new release to fix this, so we might have to wait a few months until SDL 2.0.10.
illume commentedon Nov 15, 2018
I guess we could make a PR which is 2.0.9 with that patch?