Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing mpv.app bundle #46532

Closed
4 tasks done
chainikdn opened this issue Nov 9, 2019 · 6 comments
Closed
4 tasks done

Missing mpv.app bundle #46532

chainikdn opened this issue Nov 9, 2019 · 6 comments
Labels
outdated PR was locked due to age

Comments

@chainikdn
Copy link
Contributor

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

  • ran brew update and can still reproduce the problem?
  • ran brew doctor, fixed all issues and can still reproduce the problem?
  • ran brew gist-logs <formula> (where <formula> is the name of the formula that failed) and included the output link?
  • if brew gist-logs didn't work: ran brew config and brew doctor and included their output with your issue?

What you were trying to do (and why)

install mpv and get a mpv.app

What happened (include command output)

mpv.app is missing since the mpv.rb restoration with ver. 0.30.0

What you expected to happen

in the previous mpv.rb version there was a call to the bundle generator

system "python3", "TOOLS/osxbundle.py", "build/mpv"
    prefix.install "build/mpv.app

and now it's missing

@fxcoudert
Copy link
Member

This is on purpose, most Homebrew formulas do not install .app bundles, but apps that run from command-line. If you want/need the .app, please use the cask.

@chainikdn
Copy link
Contributor Author

I don't want the cask cause it doesn't support Vapoursynth.

@SMillerDev
Copy link
Member

You can maintain a copy in your own tap that builds the app.

@StV0911
Copy link

StV0911 commented Nov 15, 2019

You can maintain a copy in your own tap that builds the app.

Could you please describe to a total noob like me the steps how to do it?
Big thanks for help

@droukd
Copy link

droukd commented Nov 18, 2019

Could you please describe to a total noob

Just add

    system "python3", "TOOLS/osxbundle.py", "build/mpv"
    prefix.install "build/mpv.app"

after system "python3", "waf", "install"
in install file located /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/mpv.rb.
Then reinstall with building from source:
brew reinstall -s mpv

And here is your app, ready to go on the system:
ln -s /usr/local/Cellar/mpv/0.30.0/mpv.app /Applications

@StV0911
Copy link

StV0911 commented Nov 18, 2019

Could you please describe to a total noob

Just add

    system "python3", "TOOLS/osxbundle.py", "build/mpv"
    prefix.install "build/mpv.app"

after system "python3", "waf", "install"
in install file located /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/mpv.rb.
Then reinstall with building from source:
brew reinstall -s mpv

And here is your app, ready to go on the system:
ln -s /usr/local/Cellar/mpv/0.30.0/mpv.app /Applications

@droukd
big thanks to you!
It works like a charme!!! :-)
Greetings
StV

@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

No branches or pull requests

5 participants