Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluidsynth 2.0.8 crashes on MacOS Mojave #46643

Closed
romanbsd opened this issue Nov 12, 2019 · 11 comments
Closed

Fluidsynth 2.0.8 crashes on MacOS Mojave #46643

romanbsd opened this issue Nov 12, 2019 · 11 comments
Labels
outdated PR was locked due to age upstream issue An upstream issue report is needed

Comments

@romanbsd
Copy link

What you were trying to do (and why)

Run fluidsynth 2.0.8 on MacOS Mojave
Note that 2.0.7 from commit 21a3510 , works fine.

What happened (include command output)

crash

Command output
$ lldb `which fluidsynth`
(lldb) target create "/usr/local/bin/fluidsynth"
rCurrent executable set to '/usr/local/bin/fluidsynth' (x86_64).
(lldb) run ./defaultSoundfont.sf2 Beethoven-Moonlight-Sonata.mid 
Process 34213 launched: '/usr/local/bin/fluidsynth' (x86_64)
FluidSynth runtime version 2.0.8
Copyright (C) 2000-2019 Peter Hanappe and others.
Distributed under the LGPL license.
SoundFont(R) is a registered trademark of E-mu Systems, Inc.

fluidsynth: warning: No preset found on channel 9 [bank=128 prog=0]
Process 34213 stopped

  • thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x60f3b0)
    frame #0: 0x00000001000d9b9c libfluidsynth.2.dylib'new_fluid_core_audio_driver2 + 76
    libfluidsynth.2.dylib'new_fluid_core_audio_driver2:
    -> 0x1000d9b9c <+76>: movups %xmm0, 0x30(%r13)
    0x1000d9ba1 <+81>: movups %xmm0, 0x40(%r13)
    0x1000d9ba6 <+86>: movups %xmm0, 0x50(%r13)
    0x1000d9bab <+91>: movups %xmm0, 0x20(%r13)
    Target 0: (fluidsynth) stopped.
    (lldb) bt
  • thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x60f3b0)
    • frame #0: 0x00000001000d9b9c libfluidsynth.2.dylib'new_fluid_core_audio_driver2 + 76
      frame #1: 0x00000001000f98e4 libfluidsynth.2.dylib'new_fluid_audio_driver + 38
      frame #2: 0x000000010000515f fluidsynth'main + 3034
      frame #3: 0x00007fff6957f3d5 libdyld.dylib'start + 1
      (lldb)

What you expected to happen

Not crash

Step-by-step reproduction instructions (by running brew install commands)

brew install fluidsynth
fluidsynth soundfont.sf midifile.mid
@SMillerDev
Copy link
Member

What makes you think this is specific to homebrew? It seems this needs to be reported to the fluidsynth developers instead.

@romanbsd
Copy link
Author

Fair enough. But the thing is, that the homebrew now ships fluidsynth which is unusable.

@romanbsd
Copy link
Author

@jonchang jonchang added the upstream issue An upstream issue report is needed label Nov 13, 2019
@SMillerDev
Copy link
Member

Fair enough. But the thing is, that the homebrew now ships fluidsynth which is unusable.

I'd say the issue is that fluidsynth tagged a release that is unusable. Is there a patch in the issue you linked that could be backported? (I only had time for a quick look through it)

@romanbsd
Copy link
Author

Not at the moment. However I can produce a patch that will revert the problematic commit. FluidSynth/fluidsynth@a94bc82

@romanbsd
Copy link
Author

Here's the patch.
fluidsynth.patch.txt

P.S. Perhaps this fix is also needed for MacOS - FluidSynth/fluidsynth#593

@lilyinstarlight
Copy link
Contributor

Hello! Just thought I'd chime in and say it was caused by undefined behaviour in the CoreAudio driver for FluidSynth that has been around for a while but finally started causing crashes due to another change that landed in 2.0.8. Version 2.0.9 has just been released with fixes for both the undefined behaviour and an implicit function declaration issue (the change mentioned earlier that caused the crashes to start).

See both FluidSynth/fluidsynth#591 (the reported issue and linked earlier here) and FluidSynth/fluidsynth#594 (the PR fixing the undefined behaviour) for more details.

I just bumped the version in my local Homebrew and v2.0.9 no longer crashes for me.

https://github.com/FluidSynth/fluidsynth/releases/tag/v2.0.9

Thanks!

@Bo98
Copy link
Member

Bo98 commented Nov 15, 2019

Looks like they forgot to update the version number in fluidsynth --version for 2.0.9.

@lilyinstarlight
Copy link
Contributor

@Bo98 Yeah, I noticed that and this seems to be a quick, unexpected release for the 2.0.x branch to fix this issue. 2.1.0 is probably coming out within the next 2 weeks according to https://github.com/FluidSynth/fluidsynth/releases/tag/v2.1.0.rc1 and already has an updated version number in the master branch if I remember correctly.

@DanEble
Copy link

DanEble commented Dec 11, 2019

FluidSynth 2.1 was released on December 1.

@fxcoudert
Copy link
Member

We welcome a pull request to update it.

@lock lock bot added the outdated PR was locked due to age label Jan 27, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age upstream issue An upstream issue report is needed
Projects
None yet
Development

No branches or pull requests

7 participants