Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sierra bottle sha256 for rust #4960

Closed
wants to merge 1 commit into from

Conversation

kevinastone
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --new-formula <formula> (after doing brew install <formula>)?

@MikeMcQuaid
Copy link
Member

This won't work unfortunately; you need to wait for us to build and upload one and @zmwangx can provide more details on why this wasn't done already.

@kevinastone
Copy link
Contributor Author

@MikeMcQuaid ah, ok. Was trying to figure out how to get a sierra bottle (it takes hours to build from source).

@kevinastone kevinastone deleted the rust-bottle branch September 18, 2016 19:29
@zmwangx
Copy link
Contributor

zmwangx commented Sep 18, 2016

See #4841. I think upstream has a patch or something (probably need to dig up some discussions), but we haven't got to that yet because apparently there's no avid Rust programmer on our team. @ilovezfs knows more than I do on this issue, he actually did the research.

@zmwangx
Copy link
Contributor

zmwangx commented Sep 18, 2016

it takes hours to build from source.

Now it won't build from source. Which is why we don't have a bottle.

@kevinastone
Copy link
Contributor Author

Ah, maybe that's what up. My source build just ran for 4-5 hours and I finally bailed.

@MikeMcQuaid
Copy link
Member

@zmwangx Maybe worth a Maximum OS X requirement?

@zmwangx
Copy link
Contributor

zmwangx commented Sep 18, 2016

My source build just ran for 4-5 hours

According to my experience it should get stuck early.

@zmwangx
Copy link
Contributor

zmwangx commented Sep 18, 2016

Always good to set --verbose.

@zmwangx
Copy link
Contributor

zmwangx commented Sep 18, 2016

@zmwangx Maybe worth a Maximum OS X requirement?

If it saves people 4-5 hours, definitely, will do right away.

zmwangx added a commit to zmwangx/homebrew-core that referenced this pull request Sep 18, 2016
See Homebrew#4960 for an example of an unfortunate soul who wasted 4-5 valuable
hours in his life just because we let him.
@zmwangx
Copy link
Contributor

zmwangx commented Sep 18, 2016

See #4962 which temporarily disables it on Sierra.

@kevinastone
Copy link
Contributor Author

kevinastone commented Sep 18, 2016

Just tested again. It gets caught in a loop after that malloc error after about ~45 minutes (at 78%).

@zmwangx
Copy link
Contributor

zmwangx commented Sep 18, 2016

Yeah that's exactly the "expected" behavior.

@alexcrichton
Copy link
Contributor

Hello! I work over on the rust-lang/rust project, and I think I know what's going on here.

This bug was first reported on July 5, 2016 and was subsequently fixed on July 9, 2016. The fix was originally scheduled to go out in the 1.12 compiler but we backported the fix to the 1.11 compiler. This means that versions of Rust 1.10 and below are all broken on OSX 10.12.

When building from source, however, we build from the previous stable version. That is, when building the 1.11 compiler, it uses the 1.10 compiler to kick off the compilation. I believe the problem you're seeing here is that when compiling the 1.11 compiler on OSX 10.12 you need to run the 1.10 compiler, which exhibits this bug.

We currently, and unfortunately, have no way to update the boostrap compiler for the 1.11 release. You could work around this by rebuilding 1.10 with an updated jemalloc and then using that to bootstrap 1.11. That being said, the 1.12 release is being released tomorrow (Sep 29, 2016). This compiler will bootstrap from the 1.11 release, which does indeed work on OSX 10.12, so the bootstrap should be able to proceed as usual.

Basically tl;dr; this'll fix itself in 24 hours!

@alexcrichton
Copy link
Contributor

Rust 1.12 was just released!

@DomT4
Copy link
Member

DomT4 commented Sep 29, 2016

Thanks @alexcrichton. Appreciate the update yesterday & today ❤️. If you have a moment, do you have an opinion on the cargo issue raised in #5185 & #5392?

@alexcrichton
Copy link
Contributor

Certainly! Commented on them

@wkral wkral mentioned this pull request Sep 30, 2016
4 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants