Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

szip formula should be removed #96930

Closed
6 tasks done
Bo98 opened this issue Mar 15, 2022 · 2 comments
Closed
6 tasks done

szip formula should be removed #96930

Bo98 opened this issue Mar 15, 2022 · 2 comments
Assignees
Labels
outdated PR was locked due to age

Comments

@Bo98
Copy link
Member

Bo98 commented Mar 15, 2022

The szip has a license that appears to not be fully open source: https://support.hdfgroup.org/doc_resource/SZIP/Commercial_szip.html.

There is now an open-source replacement however: libaec. We already ship it so we should migrate away form szip as soon as possible.


Progress:

@cho-m
Copy link
Member

cho-m commented Mar 15, 2022

I did see this when looking into hdf5.

I had opened #96928 relating to migrating hdf5@1.10 from szip to libaec, but can wait for fixing conflicts_with first.

I just opened #96933 to switch conflicts_with to keg_only.


Most other usage of szip is due to hdf5's dependency tree, but may need to also consider downgrading 1.13.0 back to 1.12.1.

@cho-m
Copy link
Member

cho-m commented Mar 16, 2022

At this point, only need to migrate hdf formula and dependents in single PR before disabling szip.

However, we probably should decide if hdf should be downgraded to 1.12.1 beforehand or same PR, and the best procedure to do this. There are a number of dependents revision bumped so manually reverting files may break. Not sure if best option is to downgrade via version_scheme.

@cho-m cho-m added the in progress Stale bot should stay away label Mar 29, 2022
@cho-m cho-m self-assigned this Mar 29, 2022
@cho-m cho-m removed the in progress Stale bot should stay away label Mar 31, 2022
@cho-m cho-m mentioned this issue Mar 31, 2022
6 tasks
@cho-m cho-m closed this as completed Apr 19, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label May 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants