-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pnpm@8 8.15.7 (new formula) #170007
pnpm@8 8.15.7 (new formula) #170007
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
Please indicate how this would fill our criteria for versioned formulas (https://docs.brew.sh/Versions) and why we might want to ship an older version? |
Criteria:
The different versions of
These are not unstable versions.
pnpm v8 has it's own branch that is being regularly maintained. This is their security policy which also means that v7 will not be something that will be added to Homebrew.
Version 8 is a just a different branch from the main
Doesn't depend on versioned formulae
Used
Doesn't have a
Lots of projects still rely on an older version of |
Thanks for the explanation, is there any indication until when it is supported? |
when what is supported? |
Until when this version of pnpm is supported |
This version of pnpm is supported (version 8). I mentioned that version 7 isn't supported because I said |
But in what term is version 8 supported? Until the inevitable heat death of the universe? Until next week? |
1 year |
Could you add a |
8619d7d
to
449e22c
Compare
Got them to include the date on their policy page: |
Initial copy of pnpm Changed live check Updated sha hash Updated class name Formatted Updated caveat version Updated binary names in bin Updated testing to pnpm@8 Added alias for pnpm@9 for default pnpm Disable pnpm@8 when unmaintained schedule pnpm@8: remove bottle block and fix style issue Signed-off-by: Rui Chen <rui@chenrui.dev>
5e2cda8
to
03081e0
Compare
@Pandoks, thanks for your first contribution to homebrew-core! 🎉 🥇 Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!! |
Checklist:
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Description:
pnpm
similar tonode
(ie.node@20
,node@18
, etc)pnpm@8
as akeg_only
formula