Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Commit

Permalink
fontconfig: add comment about why the bottle isn't relocatable
Browse files Browse the repository at this point in the history
  • Loading branch information
@jacknagel
jacknagel committed Apr 4, 2014
1 parent d9f6616 commit d6f67ae
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Library/Formula/fontconfig.rb
View file
Expand Up @@ -5,8 +5,9 @@ class Fontconfig < Formula
url 'http://fontconfig.org/release/fontconfig-2.11.1.tar.bz2'
sha1 '08565feea5a4e6375f9d8a7435dac04e52620ff2'

# The bottle tooling is too lenient and thinks fontconfig

This comment has been minimized.

Sign in to view

Copy link
@adamv

adamv Apr 4, 2014

Contributor

Do we need a DSL hack to tell the tool this?

This comment has been minimized.

Sign in to view

Copy link
@mistydemeo

mistydemeo Apr 4, 2014

Member

Argh, good catch. Meant to check this before pushing.

This comment has been minimized.

Sign in to view

Copy link
@jacknagel

jacknagel Apr 4, 2014

Author Contributor

The bottle tooling needs to be fixed to not make this mistake.

This comment has been minimized.

Sign in to view

Copy link
@MikeMcQuaid

MikeMcQuaid Apr 5, 2014

Member

Indeed. It doesn't contain /usr/local or /usr/local/Cellar as strings anywhere? Seems odd.

This comment has been minimized.

Sign in to view

Copy link
@jacknagel

jacknagel Apr 5, 2014

Author Contributor

It's this hack that breaks it.

https://github.com/Homebrew/homebrew/blob/78ac9fe72a8210d7fca6287ac40d235a52e59991/Library/Homebrew/cmd/bottle.rb#L164-168

Unfortunately removing it makes a ton of things unrelocatable despite /usr/local only showing up in documentation.

This comment has been minimized.

Sign in to view

Copy link
@MikeMcQuaid

MikeMcQuaid Apr 5, 2014

Member

Sucks. We should maybe just try and rewrite the documentation.
# is relocatable, but it has hardcoded paths in the executables.
bottle do
cellar :any
revision 2
sha1 "7f481637395b324e3f84ca098f9cf85d1ac9f5cb" => :mavericks
sha1 "1a5cea57cdd15d077e829fe93a2d794655249ba5" => :mountain_lion
Expand Down

0 comments on commit d6f67ae

Please sign in to comment.