This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Defaulting to EDITOR, then checking for the mate command, and then using vim as a last resort. Signed Off By: Max Howell <max@methylblue.com> Plain brew edit still uses Textmate though because a client that supported a project concept is required for that particular feature. Patches for that welcome.
- Loading branch information
Showing
2 changed files
with
19 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e23a612
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work if you have for instance:
EDITOR='mate -w'
e23a612
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hit the same issue as adam
e23a612
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guys, tons of stuff breaks if your editor has args... this is why the mate command acts like "mate -w" if you symlink it to "mate_wait", and then set EDITOR=mate_wait
e23a612
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'm living in a non-command-line world if this is the first breakage I've noticed. Thanks for the symlink tip.
(It might help if "The Internet" wasn't recommending "mate -w" as the editor, I suppose.)
e23a612
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know that Andre, thanks. However I've got a patch in my queue which splits the EDITOR command by space anyway. Can anyone see this causing any problems? I gave it reasonable thought and went with "it'll be ok".
At least with the patch the apparently common usecase on mac of "mate -w" (I did this too until recently) will work.