makensis fails to compile on OS X 10.9.2

[nelsonjchen]

Funny enough, this particular and exact error showed up in one of the CI build logs some time back.

https://groups.google.com/forum/#!topic/brew-test-bot/RdlApLj423s

Stuff from troubleshooting guide:

https://gist.github.com/nelsonjchen/11299996

[jcliff]

I also ran into this issue. The problem is clang is stripping "dead code". Avoid this by specifying STRIP_CP=no to scons.

[adamv]

I get this error locally:

scons: warning: The build_dir keyword has been deprecated; use the variant_dir keyword instead.
File "/private/tmp/makensis-xa7R/nsis-2.46-src/SConstruct", line 605, in <module>
/bin/sh: wx-config: command not found
OSError: 'wx-config --cxxflags --libs' exited 127:
  File "/private/tmp/makensis-xa7R/nsis-2.46-src/SConstruct", line 605:
    defenv.SConscript(dirs = path, build_dir = build_dir, duplicate = False, exports = exports)
  File "/Users/adamv/homebrew/Cellar/scons/2.3.1/libexec/scons-local/SCons/Script/SConscript.py", line 546:
    return _SConscript(self.fs, *files, **subst_kw)
  File "/Users/adamv/homebrew/Cellar/scons/2.3.1/libexec/scons-local/SCons/Script/SConscript.py", line 260:
    exec _file_ in call_stack[-1].globals
  File "/private/tmp/makensis-xa7R/nsis-2.46-src/Contrib/NSIS Menu/SConscript", line 77:
    nsis_menu[0].env.ParseConfig('wx-config --cxxflags --libs')
  File "/Users/adamv/homebrew/Cellar/scons/2.3.1/libexec/scons-local/SCons/Environment.py", line 1555:
    return function(self, self.backtick(command))
  File "/Users/adamv/homebrew/Cellar/scons/2.3.1/libexec/scons-local/SCons/Environment.py", line 597:
    raise OSError("'%s' exited %d" % (command, status))

[jacknagel]

ld: warning: option -s is obsolete and being ignored
ld: internal error: atom not found in symbolIndex(__ZN14LangStringListD2Ev) for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Having fixed the same problem in a different formula (14833f9) earlier, I am tempted to make superenv ignore -s.

I'd file a bug with Apple but their process is so messed up that I literally do not know how.

[adamv]

I came to the same conclusion for another formula I was working on today, but I forget which.

[jetztgradnet]

I have the exact same problem. My environment is also the same as posted by @nelsonjchen at https://gist.github.com/nelsonjchen/11299996.

Is there a local work-around? I tried messing with the formula, but without success. How would I remove the -s flag from the linker, as suggested by @jacknagel? The linked commit is a make call, not scons, so this would probably be different here, I guess.

[jetztgradnet]

The stripping (-s flag to the linker) is really the problem. I got it to work by modifying the formula in /usr/local/Library/Formula/makensis.rb and replacing the call to scons "makensis" with system "scons STRIP=0 makensis"

[adamv]

Still fails locally for me with a wx-config error, likely something to do with my install not being to /usr/local.

[adamv]

Willing to pull the strip fix if someone makes a pull request though.

[adamv]

Ok, makensis is seeing that I have wxmac installed and trying to use it even though there is no dependency on it. Can we specify this explicitly?