Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

ngrok failed to build on 10.10 #43019

Closed
dva opened this issue Aug 17, 2015 · 15 comments
Closed

ngrok failed to build on 10.10 #43019

dva opened this issue Aug 17, 2015 · 15 comments

Comments

@dva
Copy link

dva commented Aug 17, 2015

https://gist.github.com/dva/b313f5a60a45ad92ab26

@dunn
Copy link
Contributor

dunn commented Aug 17, 2015

I'm getting the same error. The formula should probably be re-written using go_resources instead of using the Makefile which runs go get; there's also a build-time dependency on https://github.com/jteeuwen/go-bindata which will make things a little complicated.

@aklinkert
Copy link

👍 Also fails for me.

@chris-obv
Copy link

Not to pile it on, but same error for me.

@sysulq
Copy link

sysulq commented Aug 19, 2015

Same error.

@dunn dunn added the go label Aug 20, 2015
@dunn
Copy link
Contributor

dunn commented Aug 20, 2015

If anyone wants to take a crack at fixing this, we'd be very grateful!

@dva
Copy link
Author

dva commented Aug 20, 2015

@dunn what about Ngrok 2.x?

@riv247
Copy link

riv247 commented Aug 20, 2015

Same issue for me. However I've been able to use brew cask install ngrok to get a working pre-built binary for the time being.

@dunn
Copy link
Contributor

dunn commented Aug 20, 2015

@dva it looks like the 2.x branch is non-free. If I'm wrong, though, a PR updating the version and fixing the build would be even better.

@rgaidot
Copy link

rgaidot commented Aug 21, 2015

@zackhsi
Copy link

zackhsi commented Aug 21, 2015

+1. This works for me:

brew install Caskroom/cask/ngrok

@ojongerius
Copy link
Contributor

Installing from HEAD works too:

✘ ojongerius@hipster  ~  brew install ngrok --HEAD
==> Cloning https://github.com/inconshreveable/ngrok.git
Updating /Library/Caches/Homebrew/ngrok--git
==> Checking out branch master
==> make release-client
🍺  /usr/local/Cellar/ngrok/HEAD: 4 files, 11M, built in 54 seconds

I've raised #260 asking them to build a new release. When that's done we'll have to update the Formula.

@ojongerius
Copy link
Contributor

Fixed upstream, will be fixed by #43323.

 ✘ ojongerius@hipster  /usr/local   bump_ngrok  brew install --verbose --debug ngrok
/usr/local/Library/brew.rb (Formulary::FormulaLoader): loading /usr/local/Library/Formula/ngrok.rb
/usr/local/Library/brew.rb (Formulary::FormulaLoader): loading /usr/local/Library/Formula/go.rb
Warning: Formula file is modified!
Building from source because Library/Formula/ngrok.rb has local changes
To install from a bottle instead, run with --force-bottle
/usr/local/Library/Homebrew/build.rb (Formulary::FromPathLoader): loading /usr/local/Library/Formula/ngrok.rb
/usr/local/Library/Homebrew/build.rb (Formulary::FormulaLoader): loading /usr/local/Library/Formula/go.rb
/usr/local/Library/Homebrew/build.rb (Formulary::FormulaLoader): loading /usr/local/Library/Formula/mercurial.rb
==> Downloading https://github.com/inconshreveable/ngrok/archive/1.7.1.tar.gz
Already downloaded: /Library/Caches/Homebrew/ngrok-1.7.1.tar.gz
==> Verifying ngrok-1.7.1.tar.gz checksum
tar xf /Library/Caches/Homebrew/ngrok-1.7.1.tar.gz
==> make release-client
GOOS="" GOARCH="" go get github.com/jteeuwen/go-bindata/go-bindata
bin/go-bindata -nomemcopy -pkg=assets -tags=release \
        -debug=false \
        -o=src/ngrok/client/assets/assets_release.go \
        assets/client/...
bin/go-bindata -nomemcopy -pkg=assets -tags=release \
        -debug=false \
        -o=src/ngrok/server/assets/assets_release.go \
        assets/server/...
go get -tags 'release' -d -v ngrok/...
github.com/inconshreveable/mousetrap (download)
github.com/rcrowley/go-metrics (download)
Fetching https://gopkg.in/inconshreveable/go-update.v0?go-get=1
Parsing meta tags from https://gopkg.in/inconshreveable/go-update.v0?go-get=1 (status code 200)
get "gopkg.in/inconshreveable/go-update.v0": found meta tag main.metaImport{Prefix:"gopkg.in/inconshreveable/go-update.v0", VCS:"git", RepoRoot:"https://gopkg.in/inconshreveable/go-update.v0"} at https://gopkg.in/inconshreveable/go-update.v0?go-get=1
gopkg.in/inconshreveable/go-update.v0 (download)
github.com/kardianos/osext (download)
github.com/kr/binarydist (download)
Fetching https://gopkg.in/inconshreveable/go-update.v0/check?go-get=1
Parsing meta tags from https://gopkg.in/inconshreveable/go-update.v0/check?go-get=1 (status code 200)
get "gopkg.in/inconshreveable/go-update.v0/check": found meta tag main.metaImport{Prefix:"gopkg.in/inconshreveable/go-update.v0", VCS:"git", RepoRoot:"https://gopkg.in/inconshreveable/go-update.v0"} at https://gopkg.in/inconshreveable/go-update.v0/check?go-get=1
get "gopkg.in/inconshreveable/go-update.v0/check": verifying non-authoritative meta tag
Fetching https://gopkg.in/inconshreveable/go-update.v0?go-get=1
Parsing meta tags from https://gopkg.in/inconshreveable/go-update.v0?go-get=1 (status code 200)
Fetching https://gopkg.in/yaml.v1?go-get=1
Parsing meta tags from https://gopkg.in/yaml.v1?go-get=1 (status code 200)
get "gopkg.in/yaml.v1": found meta tag main.metaImport{Prefix:"gopkg.in/yaml.v1", VCS:"git", RepoRoot:"https://gopkg.in/yaml.v1"} at https://gopkg.in/yaml.v1?go-get=1
gopkg.in/yaml.v1 (download)
github.com/inconshreveable/go-vhost (download)
code.google.com/p/log4go (download)
warning: code.google.com is shutting down; import path code.google.com/p/log4go will stop working
github.com/nsf/termbox-go (download)
github.com/mattn/go-runewidth (download)
github.com/gorilla/websocket (download)
go install -tags 'release' ngrok/main/ngrok
==> Cleaning
Fixing /usr/local/Cellar/ngrok/1.7.1/bin/ngrok permissions from 755 to 555
==> Finishing up
ln -s ../Cellar/ngrok/1.7.1/bin/ngrok ngrok
==> Summary
🍺  /usr/local/Cellar/ngrok/1.7.1: 4 files, 11M, built in 48 seconds

@ojongerius
Copy link
Contributor

I think we can close this one @dva / @dunn ?

@dva
Copy link
Author

dva commented Aug 27, 2015

@ojongerius now it works, thanks!

@dunn
Copy link
Contributor

dunn commented Aug 27, 2015

Thanks for following up on this, @ojongerius!

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests