This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
tkdiff #10100
Closed
tkdiff #10100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a Tcl/Tk script using wish, already installed on OS X.
| # It's enough to just replace "false" with the main program this | ||
| # formula installs, but it'd be nice if you were more thorough. | ||
| # Test the test with `brew test tkdiff`. | ||
| system "tkdiff --help" |
There was a problem hiding this comment.
Remove the comments here, and specify the path to the binary, i.e. system "#{bin}/tkdiff --help"
There was a problem hiding this comment.
I removed comments, added #{bin}/, then tried to squash and change the pull request (to f1e5ff8).
Since I'm not super git-savvy, I don't know if the pull request has been changed properly. Let me know if I need to take further action.
There was a problem hiding this comment.
Thanks, I'll squash it down to a single commit myself.
added 3 commits
February 13, 2012 09:54
It is a Tcl/Tk script using wish, already installed on OS X. Response to review comments from Jack.
|
It works well on Lion. Thanks for the formula. |
|
Pulled. |
|
Thanks for homebrew! |
jappievw
pushed a commit
to jappievw/homebrew
that referenced
this pull request
Feb 14, 2012
Closes Homebrew#10100. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Sharpie
pushed a commit
to Sharpie/homebrew
that referenced
this pull request
Sep 12, 2012
Closes Homebrew#10100. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
snakeyroc3
pushed a commit
to snakeyroc3/homebrew
that referenced
this pull request
Dec 17, 2012
Closes Homebrew#10100. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a Tcl/Tk script using wish, already installed on OS X.