This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Add new formula unar #15322
Merged
Add new formula unar #15322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| system "rm -r #{tempDirectory}" | ||
| #Copy man pages | ||
| system "cd ./Extra;mkdir #{share};mkdir #{man};mkdir #{man1}; mv ./lsar.1 #{man1}/lsar.1; mv ./unar.1 #{man1}/unar.1" | ||
| end |
There was a problem hiding this comment.
Don't chain commands in shell invocations, and calls to things like mv, cd, mkdir, etc. should be done using the included FileUtils methods rather than shelling out. e.g.:
cd 'foo' do
# do some things
end
cd 'bar' do
# do other things
end
|
Indents should be 2sp. |
|
Needs a |
|
Please squash to a single commit for review, thanks. |
| url 'http://theunarchiver.googlecode.com/files/unar1.2_src.zip' | ||
| version '1.2' | ||
| sha1 '6fcc27f6d37dc254b8c473b7616049083c566f4a' | ||
| depends_on :xcode => :xcodebuild |
There was a problem hiding this comment.
Just depends_on :xcode, no => :xcodebuild.
There was a problem hiding this comment.
Ok, should I made a new commit?
|
I have made a single commit |
|
It has passed a month, so I'm trying to bump |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This formula installs unar and lsar, the first one can extract archives with diferent formats and the last one list the contents of an archive.