This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
ecasound 2.8.1: Fix ruby support with explicit --enable-rubyecasound #19420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change formula to always pass explicit --enable-rubyecasound=<yes|no> so it works regardless of the ecasound configure's default behavior for --enable-ruby. Formula was assuming default was no, but default was actually yes, so the ruby stuff got built even when --with-ruby was not supplied, which could break the build when attempting to install in to /Library/Ruby. Fixes #19357.
handyman5
pushed a commit
to handyman5/homebrew
that referenced
this pull request
Oct 7, 2013
Change formula to always pass explicit --enable-rubyecasound=<yes|no> so it works regardless of the ecasound configure's default behavior for --enable-ruby. Formula was assuming default was no, but default was actually yes, so the ruby stuff got built even when --with-ruby was not supplied, which could break the build when attempting to install in to /Library/Ruby. Fixes Homebrew#19357. Closes Homebrew#19420. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change formula to always pass explicit --enable-rubyecasound=<yes|no>
so it works regardless of the ecasound configure's default behavior
for --enable-ruby. Formula was assuming default was no, but default was
actually yes, so the ruby stuff got built even when --with-ruby was
not supplied, which could break the build when attempting to install
in to /Library/Ruby. Fixes #19357.