Pgtap

[theory]

First commit updates pgTAP to v0.94.0. Second adds a method that installs pg_prove from CPAN, which simplifies the running of pgTAP tests.

[MikeMcQuaid]

Needs rebased on master.

[theory]

Oops, sorry, thought I just forked, but I guess I had an old fork. Rebased now.

[adamv]

There is no symbol version of this dependency

[theory]

Fixed, thanks!

[theory]

Hrm, looking at this failure and wondering if it worked before.

[MikeMcQuaid]

Will this interact with ~/.cpan at all?

[theory]

Yeah, it will leave files in ~/.cpan.

[MikeMcQuaid]

We can't modify the home directory during installation.

[theory]

Hrm. Should I add a line to rm -rf ~/.cpan? How does one usually install CPAN modules? @miyagawa, is there a cpanm flag to use a different directory? I couldn't find anything in a quick scan of the man page.

[MikeMcQuaid]

See clipsafe.rb.

[theory]

Ah ha! Switched to that approach in eaef0db. Wouldn't want to do that for something like Sqitch, which requires a shitload of modules, but for this narrow case, I think it makes a lot of sense. Thanks!

[theory]

We still have this issue:

mkdir: /usr/share/doc/postgresql: Permission denied
mkdir: /usr/share/doc/postgresql: No such file or directory

What are the permissions used by the Postgres build? Did this work for previous versions of pgTAP? Do we need to do sudo make install, perhaps?

[MikeMcQuaid]

I would guess there's a hardcoded path that needs fixed.

[theory]

Hrm. I have postgresql-9.2.3 installed. I ran the build on my box and it worked. The Perl stuff was included in /usr/local/Cellar/pgtap/0.94.0/, while the pgTAP extension was installed in /usr/local/Cellar/postgresql/9.2.3/share/postgresql/. No error creating the doc directory, which PGXS determines from pg_config --docdir. I'm mystified what the permission issue could be about on the test host(s).

[MikeMcQuaid]

There's no issue on the test host; it does a clean install every time.

[mistydemeo]

The non-server edition of OS X includes a postgres client (but not a server), which includes a /usr/bin/pg_config. Possibly that's ending up in the PATH before the postgres the build is meant to be using.

[theory]

Hey @mistydemeo. Hrm. Maybe this line doesn't do what I think it should?

ENV.prepend_path 'PATH', Formula.factory('postgresql').bin

[mistydemeo]

Nope, that looks right. Drop in a which pg_config just to see if you're getting it instead?

[theory]

Hrm. The scripts are not getting linked, either. That is, these three apps:

> ll /usr/local/Cellar/pgtap/0.94.0/libexec/bin 
total 96
-r-xr-xr-x  1 david  admin    19K Jan 15 13:59 pg_prove*
-r-xr-xr-x  1 david  admin    11K Jan 15 13:59 pg_tapgen*
-r-xr-xr-x  1 david  admin    13K Jan 15 13:59 prove*

Do I need to do something else to tell brew to link those?

[mistydemeo]

Those are in libexec, which is usually not exposed publicly.

[theory]

Oh. So should I use INSTALL_BASE=%{lib} or something instead?

[theory]

On my box, system 'which', 'pg_config' outputs /usr/local/bin/pg_config, which is correct. Want me to push that?

[mistydemeo]

Might as well, just to see what the bot is picking up.

[mistydemeo]

/bin/sh /usr/lib/postgresql/pgxs/src/makefiles/../../config/install-sh -c -d '/usr/share/postgresql/extension'
/bin/sh /usr/lib/postgresql/pgxs/src/makefiles/../../config/install-sh -c -d '/usr/share/doc/postgresql/extension'
mkdir: /usr/share/doc/postgresql: Permission denied
mkdir: /usr/share/doc/postgresql: No such file or directory

Wait, I see here: looks like it's picking up on a postgres in /usr/lib.

[mistydemeo]

Ping @MikeMcQuaid - are the bots running OS X server?

[theory]

• 58ea9cf: Using prefix instead of libexec. That gets things linked up.
• 577fbfa: Try to find out what pg_config we're using.

[MikeMcQuaid]

One of them has it installed.

[theory]

Yeah, this failure clearly shows that it is not picking up the right pg_config, even with the path prepend. WTF? I can pass PG_CONFIG to make instead.

[theory]

Oh-ho! I switched to this:

pg_config = File.join(Formula.factory('postgresql').bin, 'pg_config')
system 'make', "PG_CONFIG=#{pg_config}"
system 'make', "PG_CONFIG=#{pg_config}", 'install'

And now get this complaint:

/bin/sh: /usr/local/Cellar/postgresql/9.3.2/bin/pg_config: No such file or directory

This is because I have 9.2 installed, not 9.3. So getting the bin dir from the postgresql formula is not reliable. Should I just use /usr/local/bin/pg_config?

[mistydemeo]

Use:

pg_config = Formula.factory('postgresql').opt_prefix/'bin/pg_config'

(The path objects you return from Formula instances are Pathname objects, which support concatenation using the / operator.)

[theory]

Okay, c818ec2 should get it right!

[theory]

So much for that idea:

/bin/sh: /usr/local/opt/postgresql/bin/pg_config: No such file or directory

Also need to figure out how to get Test::Harness linked up before building TAP::Parser::SourceHandler::pgTAP, on which it depends.

[mistydemeo]

Oh, of course.

This is a consequence of the symbol-form postgres dependency, which is using an existing postgres install if present. So, on those VMs, it's not actually installing the Homebrew postgres. That's why prepending the path did nothing! The Homebrew postgres wasn't installed.

[theory]

Rebased.