Include formula for asciinema (http://asciinema.org/)

[rogeriopradoj]

No description provided.

[MikeMcQuaid]

Remove the => "2.7"; this syntax is now deprecated.

[MikeMcQuaid]

Also, please test this: install doesn't work as-is.

[rogeriopradoj]

Sorry, @MikeMcQuaid , I'll work on it.

One question: I didn't find any formula in homebrew's repo using pip install XXXXX. Is it a restriction?

[MikeMcQuaid]

Yes. If you need stuff from pip you should do it like ansible.rb.

[rogeriopradoj]

@MikeMcQuaid I just include more commits in the PR, the tests are just the minimal for know (I'll work on this).

Instead of using pip I tried to follow the instructions of https://github.com/Homebrew/homebrew/wiki/Homebrew-and-Python the best I could, using the setup.py way.

The build will run again automatically in Jenkins, or do you prefer I send a new PR?

Thanks!!!

[MikeMcQuaid]

test do

[MikeMcQuaid]

brew install and brew audit are failing. Please run brew install on your local machine and verify that it is working as expected before submitting changes to the pull request (or, in future, new pull requests).

[rogeriopradoj]

Hi, @MikeMcQuaid, thanks for the tips!

[rogeriopradoj]

Hi, @MikeMcQuaid, thanks for the tips!

[kud]

I want it I want it I want it.

[adamv]

@kud convince @rogeriopradoj to implement @MikeMcQuaid 's suggestions, or open a new clean pull request

[kud]

Yeah I think I will do a PR. Cheers.

[adamv]

Note there is a new 0.9.8 version as well.

[rogeriopradoj]

Please do it, :-)

I've used my pull request as a lab (my first contribution of a Python based
project) and, as expected for a lab project, it has blown!

I'm waiting yours to learn how to do it the right way!!!

See ya!

[adamv]

Will review an updated pull request for this.

[ku1ik]

Hey, asciinema 0.9.9 has been released. It has been rewritten in Go, so Python packaging problems go away. Now, what's the best way to package Go command line app? There are compiled binaries here https://github.com/asciinema/asciinema-cli/releases/tag/v0.9.9 , there's also easy way to build from source with make deps build && PREFIX=... make install. Thoughts?

[MikeMcQuaid]

Build it from source, thanks.