This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
libdisasm #28379
Closed
libdisasm #28379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| depends_on 'swig' if build.with? 'python' | ||
|
|
||
| def patches | ||
| # Fix the Python binding's Makefile to use the correct paths |
There was a problem hiding this comment.
Have these been reported upstream?
There was a problem hiding this comment.
Hi Adam,
No, I have not reported these fixes upstream. The changes make defining a PREFIX variable mandatory, but users of the libdisasm Python binding would not know to supply one, as the README only mentions making the supplied Makefile-swig.
There was a problem hiding this comment.
We need to make something that's either upstreamable or uses inreplace to make the absolute minimum changes required.
There was a problem hiding this comment.
Sorry for the delay in responding. I am going to close this PR for now, as I do not have the time to work on this and it's not ready to be a core formula just yet...
ghost
closed this
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a formula for libdisasm, http://bastard.sourceforge.net